Re: [opensuse-factory] Renumbering patches and the factory bot
On 30 Apr 08:24 2020, Michal Suchánek wrote:
On Thu, 30 Apr 2020 10:02:20 +0200 Michael Ströder <michael@stroeder.com> wrote:
On 4/30/20 7:05 AM, Stephan Kulow wrote:
Am 29.04.20 um 20:09 schrieb Jan Engelhardt:
Source0: s.tar.xz Patch*: [0-9]*.patch # or even "Patch*: *.diff" -- whatever it is you want for your package
The kernel packages use patches.tar.xz and get away with it. Every package with more than a dozen patches is most likely easier to handle with that approach :)
Isn't it much harder to review changes with that approach?
Not really.
First, these tarballs are typically generated from git which is easy to review in git.
Second, OBS web UI can show diffs of files inside a tarball.
It won't show for big tarballs which is the case for kernel, so let's not do this unless you are kernel. Regards, ismail -- Never attribute to malice that which is adequately explained by laziness. SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imendörffer (HRB 36809, AG Nürnberg)
On Thu, 30 Apr 2020 10:29:49 +0200 İsmail Dönmez <idoenmez@suse.com> wrote:
On 30 Apr 08:24 2020, Michal Suchánek wrote:
On Thu, 30 Apr 2020 10:02:20 +0200 Michael Ströder <michael@stroeder.com> wrote:
On 4/30/20 7:05 AM, Stephan Kulow wrote:
Am 29.04.20 um 20:09 schrieb Jan Engelhardt:
Source0: s.tar.xz Patch*: [0-9]*.patch # or even "Patch*: *.diff" -- whatever it is you want for your package
The kernel packages use patches.tar.xz and get away with it. Every package with more than a dozen patches is most likely easier to handle with that approach :)
Isn't it much harder to review changes with that approach?
Not really.
First, these tarballs are typically generated from git which is easy to review in git.
Second, OBS web UI can show diffs of files inside a tarball.
It won't show for big tarballs which is the case for kernel, so let's not do this unless you are kernel.
If your tarball with patches is so big that OBS won't show diff of it then storing it as separate files will make your spec file and changelog listing all the patches _really_ big. Don't think that's a great idea. In that case you have to review the patches where they come from which is what the kernel does. Thanks Michal -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (2)
-
İsmail Dönmez -
Michal Suchánek