[opensuse-factory] optflags = "... -m64 ..." in Factory / Staging?
Hi, at least staging gained an additional "-m64" in x86_64 %{optflags}. Is this really wanted? It breaks e.g. building valgrind, which explicitly tries to build some 32 bit code on x86_64. As the "-m64" is appended to the flags after valgrinds own "- m32", the build fails: https://build.opensuse.org/package/show/openSUSE:Factory:Staging:I/valgrind https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:I... valgrind/standard/x86_64 Kind regards, Stefan-- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Tuesday 2018-08-28 18:22, Brüns, Stefan wrote:
at least staging gained an additional "-m64" in x86_64 %{optflags}. Is this really wanted?
This issue has come up about a decade ago or so in the region of cross compiling (with RPM). The answer I remember is: yes, it is wanted, because 1. rpm was instructed to specifically build for x86_64 and 2. rpm/the distro (via optflags) does not want to rely on gcc's default (which may be a crosscompiler, e.g. --target=i586-suse-linux). Conversely, gcc must support being called with both "-m64 -m32" on the same command line. It did not always do that in the past, but current gcc8 on openSUSE adheres to it. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Dienstag, 28. August 2018 18:40:33 CEST Jan Engelhardt wrote:
On Tuesday 2018-08-28 18:22, Brüns, Stefan wrote:
at least staging gained an additional "-m64" in x86_64 %{optflags}. Is this really wanted?
This issue has come up about a decade ago or so in the region of cross compiling (with RPM). The answer I remember is: yes, it is wanted, because 1. rpm was instructed to specifically build for x86_64 and 2. rpm/the distro (via optflags) does not want to rely on gcc's default (which may be a crosscompiler, e.g. --target=i586-suse-linux).
Conversely, gcc must support being called with both "-m64 -m32" on the same command line. It did not always do that in the past, but current gcc8 on openSUSE adheres to it.
As the "-m64" is *appended* to the flags *after* valgrinds own "- m32", the build fails:
^ this On one hand, we want to have our flags appended, to have the final say on compiler options for security reasons. But this fails if it breaks required options specified by the project. Regards, Stefan -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Tuesday 2018-08-28 18:44, Brüns, Stefan wrote:
On Dienstag, 28. August 2018 18:40:33 CEST Jan Engelhardt wrote:
On Tuesday 2018-08-28 18:22, Brüns, Stefan wrote:
at least staging gained an additional "-m64" in x86_64 %{optflags}. Is this really wanted?
This issue has come up about a decade ago or so in the region of cross compiling (with RPM). The answer I remember is: yes, [...]
As the "-m64" is *appended* to the flags *after* valgrinds own "- m32", the build fails:
^ this
On one hand, we want to have our flags appended
In this one instant, I would count this as a valgrind bug. Unfortunately, there exists at least one build system in the world which does not really allow adding second round of compiler flags overriding even the user-provided CFLAGS (which in itself is already an override/append), so it's not entirely valgrind's fault... -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Hi, On Tue, Aug 28, 2018 at 09:19:06PM +0200, Jan Engelhardt wrote:
On Tuesday 2018-08-28 18:44, Brüns, Stefan wrote:
On Dienstag, 28. August 2018 18:40:33 CEST Jan Engelhardt wrote:
On Tuesday 2018-08-28 18:22, Brüns, Stefan wrote:
at least staging gained an additional "-m64" in x86_64 %{optflags}. Is this really wanted?
This issue has come up about a decade ago or so in the region of cross compiling (with RPM). The answer I remember is: yes, [...]
As the "-m64" is *appended* to the flags *after* valgrinds own "- m32", the build fails:
^ this
On one hand, we want to have our flags appended
In this one instant, I would count this as a valgrind bug.
Unfortunately, there exists at least one build system in the world which does not really allow adding second round of compiler flags overriding even the user-provided CFLAGS (which in itself is already an override/append), so it's not entirely valgrind's fault...
This was a setup bug and was reverted by Dominique already I think, meaning the -m64 is gone again. Ciao, Marcus -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (3)
-
Brüns, Stefan -
Jan Engelhardt -
Marcus Meissner