[opensuse-factory] brp-30-desktop failing with "Icon file not installed"
Hi all, I wanted to fix the arandr factory failure which is caused by: [ 4s] calling /usr/lib/rpm/brp-suse.d/brp-30-desktop [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/suse-screensavers.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/applications-kmenuedit.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/custom.menu' does not exist [ 5s] ERROR: Icon file not installed: /home/abuild/rpmbuild/BUILDROOT/arandr-0.1.10-0.x86_64//usr/share/applications/arandr.desktop (package_utility_desktop) [ 5s] Errors in installed desktop file detected. Please refer to http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros (the http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros section on %suse_update_desktop_file does not help). The problem is, that arandr.desktop contains "icon=desktop" and there is no desktop icon installed in the build system. Do I have to depend on an icon theme (which one?) for a successfull build? Is this a good idea? I doubt so. Anyway, i tried with tango-icon-theme (because it has no other dependencies) and adwaita-icon-theme (which pull in 30 more GTK packages...) and it did not help. Is the check simply buggy? -- Stefan Seyfried "For a successful technology, reality must take precedence over public relations, for nature cannot be fooled." -- Richard Feynman -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Am Freitag, 13. Dezember 2019, 08:50:19 CET schrieb Stefan Seyfried:
Hi all,
I wanted to fix the arandr factory failure which is caused by:
[...]
The problem is, that arandr.desktop contains "icon=desktop" and there is no desktop icon installed in the build system.
Do I have to depend on an icon theme (which one?) for a successfull build?
It's in breeze5-icons I had to branch the whole KDE:FW5 for some other investigation.. Have a nice weekend, Stefan. Cheers, Pete -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Fri, Dec 13, 2019 at 08:50, Stefan Seyfried <stefan.seyfried@googlemail.com> wrote:
Hi all,
I wanted to fix the arandr factory failure which is caused by:
[ 4s] calling /usr/lib/rpm/brp-suse.d/brp-30-desktop [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/suse-screensavers.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/applications-kmenuedit.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/custom.menu' does not exist [ 5s] ERROR: Icon file not installed: /home/abuild/rpmbuild/BUILDROOT/arandr-0.1.10-0.x86_64//usr/share/applications/arandr.desktop (package_utility_desktop) [ 5s] Errors in installed desktop file detected. Please refer to http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros
(the http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros section on %suse_update_desktop_file does not help).
The problem is, that arandr.desktop contains "icon=desktop" and there is no desktop icon installed in the build system.
Do I have to depend on an icon theme (which one?) for a successfull build?
Is this a good idea? I doubt so.
In general, it's best to use one of many default icon names, because they are mostly guaranteed to exist within the themes, if you aren't willing to have own icon for it https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-lat...
Anyway, i tried with tango-icon-theme (because it has no other dependencies) and adwaita-icon-theme (which pull in 30 more GTK packages...) and it did not help.
If I recall correctly, it only checks build environment, so BuildRequires with an icon theme is enough
Is the check simply buggy?
Yes, there is a good reason this PR exists https://github.com/openSUSE/brp-check-suse/pull/14 LCP [Stasiek] https://lcp.world -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Freitag, 13. Dezember 2019 08:50:19 CET Stefan Seyfried wrote:
Hi all,
I wanted to fix the arandr factory failure which is caused by:
[ 4s] calling /usr/lib/rpm/brp-suse.d/brp-30-desktop [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/suse-screensavers.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/applications-kmenuedit.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/custom.menu' does not exist [ 5s] ERROR: Icon file not installed: /home/abuild/rpmbuild/BUILDROOT/arandr-0.1.10-0.x86_64//usr/share/applicatio ns/arandr.desktop (package_utility_desktop) [ 5s] Errors in installed desktop file detected. Please refer to http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros
(the http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros section on %suse_update_desktop_file does not help).
The problem is, that arandr.desktop contains "icon=desktop" and there is no desktop icon installed in the build system.
"desktop" is not part of the icon naming specification. You will end up with either no icon or maybe an unfitting one. The correct name here is likely "preferences-desktop". Changing the icon is not supported by suse_update_desktop_file: $> sed -i -e 's/Icon=.*/Icon=preferences-desktop' arandr.desktop Kind regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019
Am 13.12.19 um 16:12 schrieb Stefan Brüns:
On Freitag, 13. Dezember 2019 08:50:19 CET Stefan Seyfried wrote:
Hi all,
I wanted to fix the arandr factory failure which is caused by:
[ 4s] calling /usr/lib/rpm/brp-suse.d/brp-30-desktop [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/suse-screensavers.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/applications-kmenuedit.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/custom.menu' does not exist [ 5s] ERROR: Icon file not installed: /home/abuild/rpmbuild/BUILDROOT/arandr-0.1.10-0.x86_64//usr/share/applicatio ns/arandr.desktop (package_utility_desktop) [ 5s] Errors in installed desktop file detected. Please refer to http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros
(the http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros section on %suse_update_desktop_file does not help).
The problem is, that arandr.desktop contains "icon=desktop" and there is no desktop icon installed in the build system.
"desktop" is not part of the icon naming specification. You will end up with either no icon or maybe an unfitting one.
It was actually slightly different, a patch changed "icon=desktop" to "icon=package_utility_desktop". This icon was in desktop-data, but apparently is no more. (package_utility_desktop also actually is what is mentioned in the error). Anyway, I looked into /usr/lib/rpm/brp-desktop.data/xdg_menu and found that "video-display" is a whitelisted icon name, so that the icon does not even need to be available in the build system. Lucky me this icon fits the application well ;-)
The correct name here is likely "preferences-desktop". Changing the icon is not supported by suse_update_desktop_file: $> sed -i -e 's/Icon=.*/Icon=preferences-desktop' arandr.desktop
preferences-desktop would have been too generic, for arandr, a "display" or "monitor" icon is fitting, so "video-display" is fine. Thanks for the hint, this really helped. A fix for arandr is on its way to factory. -- Stefan Seyfried "For a successful technology, reality must take precedence over public relations, for nature cannot be fooled." -- Richard Feynman -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (4)
-
Hans-Peter Jansen -
Stasiek Michalski -
Stefan Brüns -
Stefan Seyfried