[opensuse-factory] libtirpc-devel: incorrect header install path
libtirpc-devel places headers into /usr/include but the standard practice is to put them into /usr/include/tirpc and add -I/usr/include/tirpc to pkg-config. This breaks things like zfsonlinux. I opened a bug: https://bugzilla.opensuse.org/show_bug.cgi?id=1122665 I tried to work around this in zfsonlinux, but one of the developers said this is better fixed in tumbleweed: https://github.com/zfsonlinux/zfs/pull/8313 For background about the issue, see: https://fedoraproject.org/wiki/Changes/SunRPCRemoval The libtirpc maintainer seems to be unavailable right now, could someone take a look at this please? -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Hi, On 21 Jan 07:29, Rafael Kitover wrote:
libtirpc-devel places headers into /usr/include but the standard practice is to put them into /usr/include/tirpc and add -I/usr/include/tirpc to pkg-config.
This breaks things like zfsonlinux.
I opened a bug:
https://bugzilla.opensuse.org/show_bug.cgi?id=1122665
I tried to work around this in zfsonlinux, but one of the developers said this is better fixed in tumbleweed:
https://github.com/zfsonlinux/zfs/pull/8313
For background about the issue, see:
https://fedoraproject.org/wiki/Changes/SunRPCRemoval
The libtirpc maintainer seems to be unavailable right now, could someone take a look at this please?
This is basically a zfsonlinux bug, because: 1. They should let pkg-config figure out cflags and libs and use that, instead of hardcoding a directory. 2. One should use #include <rpc/*.h> style includes, which is even noted by the wiki page you posted. Having said that, moving headers into /usr/include/tirpc for compatibility with other distros wouldn't hurt. But, I'm not the libtirpc maintainer. Regards, ismail -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
On Jan 21 2019, İsmail Dönmez <idoenmez@suse.de> wrote:
On 21 Jan 07:29, Rafael Kitover wrote:
libtirpc-devel places headers into /usr/include but the standard practice is to put them into /usr/include/tirpc and add -I/usr/include/tirpc to pkg-config.
This breaks things like zfsonlinux.
Why does it break? If the headers are placed in /usr/include they are found without any special include path. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On lundi 21 janvier 2019 16:58:25 CET Andreas Schwab wrote:
On Jan 21 2019, İsmail Dönmez <idoenmez@suse.de> wrote:
On 21 Jan 07:29, Rafael Kitover wrote:
libtirpc-devel places headers into /usr/include but the standard practice is to put them into /usr/include/tirpc and add -I/usr/include/tirpc to pkg-config.
This breaks things like zfsonlinux.
Why does it break? If the headers are placed in /usr/include they are found without any special include path.
It breaks because there's an incorrect #include in zfs: ./lib/libspl/include/rpc/xdr.h:41:#include <tirpc/rpc/xdr.h> ↑ this should be #include <rpc/xdr.h> but the compiler would likely complain because the file name is the same as the one it tries to include. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Mon, Jan 21, Rafael Kitover wrote:
libtirpc-devel places headers into /usr/include but the standard practice is to put them into /usr/include/tirpc and add -I/usr/include/tirpc to pkg-config.
This breaks things like zfsonlinux.
I opened a bug:
As one of the major driver of the sunrpc to tirpc move, even upstream, I can only say: Closed as invalid. We will not break hundred of correct implemented packages to workaround one broken one. tirpc was always developed in mind as drop in replacement for sunrpc, and we spend a lot of efford in making it as easy and simple as possible. This includes, that you can install libtirpc in the same places as sunrpc and 99% of the sunrpc code will compile with any change needed. Your suggestion would break all this packages immeaditly. Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Mon, Jan 21, 2019 at 9:08 AM, Thorsten Kukuk <kukuk@suse.de> wrote:
As one of the major driver of the sunrpc to tirpc move, even upstream, I can only say: Closed as invalid. We will not break hundred of correct implemented packages to workaround one broken one.
tirpc was always developed in mind as drop in replacement for sunrpc, and we spend a lot of efford in making it as easy and simple as possible. This includes, that you can install libtirpc in the same places as sunrpc and 99% of the sunrpc code will compile with any change needed. Your suggestion would break all this packages immeaditly.
Thank you I will let the ZoL people know. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (5)
-
Andreas Schwab -
Christophe Giboudeaux -
İsmail Dönmez -
Rafael Kitover -
Thorsten Kukuk