[opensuse-factory] New package review request #573940 (Papirus folders)
Hello, I submitted this package a month ago but totally forgot to send a mail here -_-' "Papirus folders" is a script made by Papirus team to change folders color of the Papirus icon theme (available in official repos). https://build.opensuse.org/request/show/573940 https://github.com/PapirusDevelopmentTeam/papirus-folders 1st time I submit a package to openSUSE, spec file may be wrong, please tell me and feel free to fix if you want. Package build is ok though. Thanks! -- ___ Alex aka DarthWound Global Steam Moderator -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Tue, 2018-03-06 at 17:28 +0100, Alex DWS wrote:
Hello, I submitted this package a month ago but totally forgot to send a mail here -_-'
"Papirus folders" is a script made by Papirus team to change folders color of the Papirus icon theme (available in official repos).
https://build.opensuse.org/request/show/573940 https://github.com/PapirusDevelopmentTeam/papirus-folders
1st time I submit a package to openSUSE, spec file may be wrong, please tell me and feel free to fix if you want. Package build is ok though.
Hi Alex, I'm a member of the openSUSE Review team and had a quick look at your submission to the devel project. There are a few things I commented on, but nothing disastrous bad. Would be great if you could incorporate those comments into an updated submission. Cheers, Dominique
Hi Dominique and thank you, I'll work on it later. I understood everything you pointed out, but regarding the rpmlint warning does that mean that I have to modify the script myself or should I ask to upstream? -- ___ Alex aka DarthWound Global Steam Moderator Le mardi 06 mars 2018 à 17:35 +0100, Dominique Leuenberger / DimStar a écrit :
On Tue, 2018-03-06 at 17:28 +0100, Alex DWS wrote:
Hello, I submitted this package a month ago but totally forgot to send a mail here -_-'
"Papirus folders" is a script made by Papirus team to change folders color of the Papirus icon theme (available in official repos).
https://build.opensuse.org/request/show/573940 https://github.com/PapirusDevelopmentTeam/papirus-folders
1st time I submit a package to openSUSE, spec file may be wrong, please tell me and feel free to fix if you want. Package build is ok though.
Hi Alex,
I'm a member of the openSUSE Review team and had a quick look at your submission to the devel project. There are a few things I commented on, but nothing disastrous bad.
Would be great if you could incorporate those comments into an updated submission.
Cheers, Dominique -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Tue, 2018-03-06 at 17:45 +0100, Alex DWS wrote:
Hi Dominique and thank you, I'll work on it later.
I understood everything you pointed out, but regarding the rpmlint warning does that mean that I have to modify the script myself or should I ask to upstream?
Most likely a local patch makes sense here. For upstream, using "/usr/bin/env FOO" usually makes sense; stuff you run out of a git checkout can't really know where the respective interpreters are, so they rely on $PATH. As a packager, though, we know where things are on our system. And we prefer that stuff we install by package runs using the interpreter we intended it to run with, and not with random stuff any given user might have in other locations. Cheers Dominique
participants (2)
-
Alex DWS -
Dominique Leuenberger / DimStar