Hi, On Wed, Apr 09, 2014 at 06:28:12PM +0200, Roman Drahtmueller wrote:
Scanning through Factory logs I see that rpmlint found the following packages that have both a systemd service file as well as an init script. Since the latter is useless in Factory as it's shadowed by the service file the init script can be removed resp not installed:
I disagree.
Me too as Ludwig is right. ;)
Don't remove the init script from the source to allow for it to be available for non-systemd build targets/products. Nope, not everything is systemd.
Having both an init script and a service file does not harm. The interception nicely says that the call was redirected. See backwards compatibility ("rcpostfix restart") for management scripts.
Having an init script and not needing it is better than needing it and not having it. Apparently, it doesn't harm, but rather helps.
It's possible to implement this in a conditional way and by this we're able to make both sides happy and have the spec file cleaned up too. %if 0%{?suse_version} > 1220 install the systemd service file ln -s ../../%{_sbindir}/service %{buildroot}/%{_sbindir}/rc${srv_name} %else install the old init script ln -s <old init script> %{buildroot}/%{_sbindir}/rc${srv_name} %endif See network:samba:STABLE/samba/samba.spec for example. The build system will complain about a no longer fitting package filelist. But that's easy to handle by the same condition. https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines had been quite of help to me. Cheers, Lars -- Lars Müller [ˈlaː(r)z ˈmʏlɐ] Samba Team + SUSE Labs SUSE Linux, Maxfeldstraße 5, 90409 Nürnberg, Germany