On Friday 21 March 2014, Stanislav Brabec wrote:
Ruediger Meier wrote:
On Friday 21 March 2014, Stanislav Brabec wrote:
Ruediger Meier wrote:
Hi,
The ChangeLog is almost useless since none of the referenced bug reports is readable for non-suse people.
These changelogs were taken from the original changelog. Many of openSUSE changelogs refer to bugs that are not accessible. In ideal case, people working on SLES fix would post the same patch to openSUSE, and make a public clone of the bug report. It did not happened, and a review found these patches, where the patch was not posted to Factory nor upstream.
At least one of the added patches ("umount-avoid-readlink.patch") has no effect because it patches a deprecated and unused subdir which will be removed in next release anyway.
Yes, it is deliberate. The patch was created for SLE11 and affects the code, which is now deprecated and not used. I did not want to lose this patch and save it for upstreaming.
Upstream has already removed the whole code.
If upstream dropped "mount-deprecated" completely, then the patch as is is obsolete, and can be dropped now (or in the next version that will have no "mount-deprecated" code).
Collecting upstream-able patches will take some time. Hopefully these patches will disappear from the Factory then.
I'd like to help to get useful patches upstream. But it's hard if I'm not allowed to know anything about the fixed issues.
Well, there is also a lot of openSUSE patches, that need to check its universal validity.
Regarding the SLES11 patches:
I have reviewed all these added patches (except squashfs3 detection). See sr228719 https://build.opensuse.org/request/show/228719 The barrier barrier_documentation.patch is upstream now. I'd also like to get lscpu-improve-hypervisor-detection.patch upstream but for testing I would need dumps of /proc and /sys from such interesting systems. I also think that the vmware detection (temporary SIGSEGV handler) couldn't work together with lscpu's option -s. cu, Rudi -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org