On 31/05/17 13:13, Jan Engelhardt wrote:
On Wednesday 2017-05-31 12:23, Antonio Larrosa wrote:
Consider you have a patch that has to be applied only with gcc 7.
Coming back to what Neil Gompa and Olaf Hering mentioned (gcc v7 rpm vs gcc-7 v7 rpm), if you have something that needs to be changed for gcc 7, you are probably better off with
#if __GNUC__ >= 7 ... #else ... #endif
Please, this was only an example. Don't fix your focus on gcc and think of other uses. I mentioned the real example that got me to work on this (libid3tag needing a patch only in a Staging project because that was the only place gperf 3.1 was being used to build it so I had to break the package build in the devel project while the staging project was being accepted). Also, think of packages that need a patch for SLE12 because it uses an older cmake/whatever version when we don't want to apply the patch because it's SLE12 but because of whatever package version SLE12 uses. It's those cases the macros try to help with. -- Antonio Larrosa -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org