On Wednesday 2017-05-31 12:33, Antonio Larrosa wrote:
%pkg_version_not_equals : package != version
So, any opinion/suggestion about these macros?
So much to type. Can't we just have something similar to %requires_ge, _gt, _le, _lt, _eq, _ne?
I thought about that, but it's not actually a "requirement"
Note the "similar to" ;-)
I also thought about using %pkg_version_ge _gt ... but [..] more readable and you read the code more times than you write it :). I'm open to change the names in that sense though if it's generally accepted that those names are preferred.
(Besides "not equals" being grammatically incorrect...)
Ouch, thanks for noticing, I'll change that to _not_equal.
That's my point - writing it out using natural language inherently leads to "inconsistencies". ("equals" and "not equal" is one, "less than" and "at most" is the other. This is why I instantly thought of LT and LE instead.) Some of the spec generators floating around also use the symbolic notation (<=, =>) from the get-go without having to resort to lt/gt/etc. I think it was %{rubygem_requires blah >= 5}. If your pkg_version macro could even do that, that would be even better than having to discuss not_equals, not_equal and NE. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org