On Wed, 2020-04-29 at 17:05 +0200, Jan Engelhardt wrote:
On Wednesday 2020-04-29 15:31, Martin Wilck wrote:
"A patch (0002-Fix-disable-callback-gnome-shell-3.30- compatibility.patch) is being deleted without this removal being mentioned in the changelog."
If you look at the changelog, you can see that the patches have been *renumbered*
That is still a different filename.
The way I did it was: * renumber patch: 0102-Fix-disable-callback-gnome-shell-3.30- compatibility.patch (was 0002) This was an abbreviation of "(was: 0002-Fix-disable-callback-gnome- shell-3.30-compatibility.patch)". Obvious for human readers, I thought. Not for the bot, of course. It's fixed now (I hope).
And it is also the reason using numbers in filenames for ordering reasons are frowned upon. The only true order is determined by the %patch statements (including those possibly implicitly generated by %autopatch).
It's the filename format used by "git format-patch", and ensures correct ordering of the generated patch files. I find it helpful if the %patch number and the number in the patch file name agree. That makes it easy to verify that patches are listed in the right order in the spec file. Martin -- Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG Nürnberg GF: Felix Imendörffer -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org