El 10/06/13 09:44, Mel Gorman escribió:
I'd like to submit a new package called numad to factory.
This is a system daemon that attempts to identify processes that should be bound to NUMA nodes to improve overall performance on machines with multiple nodes. In preparation for working on the next stage of in-kernel automatic NUMA balancing support I compared current in-kernel automatic NUMA balancing, numad and manual tuning. In some cases numad can out-perform the current in-kernel implementation although in other cases it will actually perform worse than running with defaults. The expected cases where it performs better and worse are documented in the RPM description and the manual page.
https://build.opensuse.org/package/show?package=numad&project=home%3Amgorman
What is less clear to me is what project I should submit this to. I set the RPM group to System/Daemons and the Base:System devel project looked like a reasonable fit. Any suggestions on a suitable alternative or on how the package can be improved before submissions are welcome.
Just a few objections/observations, - please do not add new init scripts to factory. - the systemd service file : (comments inline [Unit] Description=numad - The NUMA daemon that manages application locality. After=syslog.target --> Not needed or used anymore, does nothing. [Service] Type=forking Can you make the service of type "simple" ? that is, a non-forking service ? the number of "forking" services implementing all the needed step correctly can be counted with one hand and there will be free fingers to hold a glass of wine. (read: all are racy at startup) If that's not possible , ensure you use the PidFile directive as well. ExecStop=/usr/sbin/numad -i 0 If the daemon reacts properly to SIGTERM please completely omit that line and let systemd to take care of the process. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org