On Wednesday 2012-08-29 14:42, Dominique Leuenberger a.k.a DimStar wrote:
Patches: The rules about patches are listed at http://en.opensuse.org/openSUSE:Packaging_Patches_guidelines . Most prominent is likely the mentioning of the patches life cycle
Most important IMHO is a patch description, which more often than not is lacking. PATCH-*-* tells you something, but not much more than where it goes, maybe a bnc number. Picking out a completely random example, OFED:Factory/librdmacm has a librdmacm-need_pthread.patch that simply adds -lpthread to the linker line. *Why* was this patch made? PATCH-FIX-UPSTREAM, yeah well, _obviously_ it fixes something, or the patch would not be there. What's missing is what error it actually attempts to fix. This helps checking in the future whether a patch is still needed, for example. Patches should be required to carry a description, akin to the what (many, but not all of,) kernel-source/patches.*.tar.bz2#*/* do: # btrfs-8084-do-not-update-atime-for-RO-snapshots.patch From: David Sterba <dsterba@suse.cz> Date: Fri, 1 Jun 2012 12:41:10 +0200 Patch-mainline: never References: FATE#306586 Subject: [PATCH] btrfs: do not update atime for RO snapshots "if a snapshot was created with -r and thus is read only, accessing files in it will update the atime. I would expect that atime is not updated on ro snapshots." This is a workaround, does not break kabi. Upcoming upstream patches extend file operations with filesystem-specific ->update_time where this check belongs. kernel-source also provides a counter-example right next to it: # btrfs-use-correct-device-for-maps.patch From: David Sterba <dsterba@suse.cz> Date: Mon, 02 Jan 2012 13:40:28 +0100 Subject: [PATCH] btrfs: use correct device for maps Reference: bnc#672923 bnc#769545 Patch-mainline: no Signed-off-by: David Sterba <dsterba@suse.cz> --- Index: linux-3.1-openSUSE-12.1/fs/proc/task_mmu.c =================================================================== --- linux-3.1-openSUSE-12.1.orig/fs/proc/task_mmu.c +++ linux-3.1-openSUSE-12.1/fs/proc/task_mmu.c [...] Again, what is the problem that makes the patch necessary? *That* are the things and info patches should convey. PATCH-*-* is mostly a copy of info found in Patch-mainline:/Upstream:, Reference:-like lines already. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org