On Fri, 2019-11-08 at 14:27 +0000, Michael Schroeder wrote:
On Fri, Nov 08, 2019 at 01:17:52PM +0100, Dominique Leuenberger / DimStar wrote:
On Fri, 2019-11-08 at 12:55 +0100, Bernhard M. Wiedemann wrote:
On 08/11/2019 11.55, Richard Brown wrote:
For the record, as someone with maintainer rights for rpm in Factory, I would be shocked, pleased, and welcoming if Stefan submitted a patch to add more flexibility in changelog filtering.
It might make more sense to attempt to send it upstream first, but regardless, I look forward to seeing such a submission in the near future.
How about https://github.com/rpm-software-management/rpm/pull/931
Thank you very much Bernhard for taking on the task of finding a solution.
To me, this looks great and, iiuc, I don't even have to configure the default value 1 in prjconf, as it is just valid as default anyway.
Looking forward to get this added to the rpm package
Why on earth are you setting %_changelog_trimtime in the project config? We have a different mechanism in place for SUSE! You're supposed to use the %_binarychangelogtrim macro instead.
# maxnum,cuttime,minnum # 2009/03/01 (SLES11 GA) %_binarychangelogtrim 0,1235862000,10
Great! Thanks for the pointer.. sadly, this is perfectly underdocumented - but it seems to be doing pretty much what we need/want I assume: maxnum = 0 means no cutting based on count of changelog entries, only on the date cuttime: the same as _changelog_trimtime would be doing minnum: how manu changes entries to keep, beyond even if going beyont the cuttime (so basically what Bernhard's _changelog_mincount would be doing. So, as you asked so nicely: why on earth is that a suse specific patch and not upstreamed? (yeah, I can use the same polemic) and why on earth is that not documented anywhere? even googling for %_binarychangelogtrim (when one already knows about it) yields just three results (dups filtered by google) * a commit message on lists.o.o to the rpm package, from August 200 * The actual patch inside OBS * and some github repo where somebody apparenly copied that patch in So, please, work with upstream to get such stuff upstreamed and eliminate downstream patches. Bernhard's approach to the issue was much leaner (on earth and on any other planet) Cheers, Dominique