On 4/30/20 11:30 PM, Martin Wilck wrote:
On Thu, 2020-04-30 at 10:02 +0200, Michael Ströder wrote:
On 4/30/20 7:05 AM, Stephan Kulow wrote:
The kernel packages use patches.tar.xz and get away with it. Every package with more than a dozen patches is most likely easier to handle with that approach :)
Isn't it much harder to review changes with that approach?
Are you saying that factory reviewers would look at every single patch and try to figure out if it's correct? In my experience, factory review is focused on formal aspects of rpm building, the spec file and the changelog. Which is fine on that level.
I will atleast check the patch likely does what the changelog description and or patchlog description say they should, people make mistakes sometimes the wrong patch gets copied over and ends up as the wrong name and gets uploaded as the wrong thing. If a package only has one maintainer and they do the update and review occasionally they might miss it. This is why having the patches in obs makes life easier for our reviews. -- Simon Lees (Simotek) http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B