Quoting Cristian Rodríguez <crrodriguez@opensuse.org>:
On Fri 28 Jun 2013 02:43:34 AM CLT, Dominique Leuenberger a.k.a. Dimstar wrote:
Can you please, for general information on -factory, explain as to the 'why' you submit all those?
Oh dear lord, over 10 years has passed since large file support was added to glibc and I __STILL_ have to explain this ?
yes... if you're that 'wise', you'd know that upfront.
I see many of them and of course also get the point.. but if they are that important: why not for 64bit systems?
Because 64 bit systems are LFS by default.
Sure.. so why don't you answer on the part that LFS_CFLAGS is empty while LFS64_CFLAGS is not? Looking at any system I ran across, you inject exactly nothing into the optflags using that getopt call.. and adding a NOP is useless in most cases.
I really don't like those additions without any explanation at ANY moment, including a reference what it does, how can the effects be tested, how can be tested if it's still needed..
Please read
http://users.suse.com/~aj/linux_lfs.html
and particulary this:
http://ac-archive.sourceforge.net/largefile/ along with all associated links. (particularly the section "problems")
right.. so I am safe in assuming that you verified the entire code where you inject those 'NOP' flags (still.. what for.. getopt LFS_CFLAGS is empty) and none of those problems listed can happen in current and future versions of the libraries? I am not willing to accept such things without at least test cases around those low-level libs! Dominique -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org