On 5/18/21 5:11 PM, Vojtěch Zeisek wrote:
Dne úterý 18. května 2021 9:37:24 CEST, Christian Goll napsal(a):
On 18.05.21 09:26, Vojtěch Zeisek wrote:
Dne úterý 18. května 2021 6:28:22 CEST, Dmitriy Perlow napsal(a):
Hello. Please remove Provides: bamtools-devel = %{version}
This indeed helps.
and add read https://en.opensuse.org/openSUSE:Packaging_scriptlet_snippets #Shared_libraries
Here I'm not sure... Using
%post /sbin/ldconfig %postun /sbin/ldconfig
Or as 'spec-cleaner -d bamtools.spec' says:
%post -p /sbin/ldconfig %postun -p /sbin/ldconfig
reduces the warnings. To be sure, it's so, because it's running this on main package and not subpackage (doesn't make sense to run on -devel)? I also still get warning:
[ 96s] RPMLINT report: [ 96s] =============== [ 97s] bamtools.x86_64: W: shared-lib-calls-exit /usr/lib64/libbamtools.so.2.5.1 exit@GLIBC_2.2.5 [ 97s] This library package calls exit() or _exit(), probably in a non-fork() [ 97s] context. Doing so from a library is strongly discouraged - when a library [ 97s] function calls exit(), it prevents the calling program from handling the [ 97s] error, reporting it to the user, closing files properly, and cleaning up any [ 97s] state that the program has. It is preferred for the library to return an [ 97s] actual error code and let the calling program decide how to handle the [ 97s] situation.
Here I don't know, the spec file doesn't call exit explicitely...
The warning means, that the library exists the program at an error instead of returning an error code to the calling binary. This is considered as bad practice, but has to be fixed upstream. So you can ignore it.
OK, thank You, submitted to OBS, I'm going to report it upstream. :-)
Its also worth noting that in some cases upstream has a really good reason for this (or the error is incorrect) and in such cases you can continue to ignore the warning (this is why its a warning not an error). -- Simon Lees (Simotek) http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B