On Thu, 30 Apr 2020 13:20:44 +0200 Michael Ströder <michael@stroeder.com> wrote:
On 4/30/20 10:54 AM, Michal Kubecek wrote:
On Thu, Apr 30, 2020 at 10:02:20AM +0200, Michael Ströder wrote:
On 4/30/20 7:05 AM, Stephan Kulow wrote:
Am 29.04.20 um 20:09 schrieb Jan Engelhardt:
Source0: s.tar.xz Patch*: [0-9]*.patch # or even "Patch*: *.diff" -- whatever it is you want for your package
The kernel packages use patches.tar.xz and get away with it. Every package with more than a dozen patches is most likely easier to handle with that approach :)
Isn't it much harder to review changes with that approach?
Quite the contrary, I would say; git and tools around it are way better suited for tracking and reviewing changes than OBS and its tools.
AFAIK for most packages there is no standard git integration in OBS. So I guess the kernel team uses extra resources not available for the simple OBS work-flow. That's ok for the kernel team. But for simple stuff? For simple stuff you probably want loose patches. There are packages like qemu or u-boot that use scripts to generate both the patches and the changelog entries. You can copy these scripts in your package to get the same.
I saw fairly simple packages with 5-6 files stuffed into a tar.gz. This always causes an extra burden on maintaining them without adding real benefit. Depends on how they get there. If you can re-create the archive in a reproducible way then it's just packaging. At least it's obvious how to get the patch files. Imagine it was stuffed in an obscpio archive.
And yes, some packagers may choose to use tar archives just to avoid the requirement to list the patches in changelog.
BTW: The most annoying issue is finding out whether patches are still valid/required. Often there are no references to why they were added.
That is completely unrelated to how they are packaged, however. The very reason why you are supposed to list patches in changelog is that it is difficult to tell from OBS alone when and why the patch was added. If you have patches in a tar archive and no way to re-create the archive reproducibly it should be a requirement to include some metadata in the patches I suppose. If the archive is created from git or similar VCS it should be possible to tell from the history there. Thanks Michal -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org