On Thu, 2022-05-12 at 16:22 +0200, Lukáš Krejza wrote:
Dne čtvrtek 12. května 2022 15:17:43 CEST, Andrei Borzenkov napsal(a):
On Thu, May 12, 2022 at 2:32 PM Martin Wilck <martin.wilck@suse.com> wrote:
It depends on how well-maintained the upstream -tod fork is. Was it a one-time fork, or do they actively pull in fixes and changes from the libfprintd project?
Well, Ubuntu unconditionally ships libfprint-tod as replacement for libfprint (they split it into libfprint "proper" and libfprint-tod shared library), at least in 20.04 and 22.04 so it must be working for them. Briefly looking in GIT
Merge tag 'v1.94.3' into tod 2021-11-02: v1.94.3 release
So it appears to be actively pulling from the original libfprint.
If this is the case, we can really drop the "proper" version and provide 2 packages built from "tod" fork instead (+ the drivers on Packman), like following:
1) libfprint-2-2 - containing libfprint-2.so.2 - built from "tod" fork package, packaged on b.o.o. 2) libfprint-2-tod1 - containing libfprint-2-tod.so.1 - built from "tod" fork package, packaged on b.o.o.
3) libfprint-2-tod1-broadcom - containing firmwares, udev rules and libfprint-2-tod-1-broadcom.so, packaged on Packman 4) libfprint-2-tod1-goodix - containing firmwares, udev rules and libfprint-2- tod-1-goodix.so, packaged on Packman
This looks like the cleaniest solution to me and also corresponds with what other distros do. I have already proposed this to Sp1rit.
Yes, that should work. However I'm unsure about dropping libfprint and replacing it with libfprint-tod entirely, given that it opens up new attack surfaces, which is obviusly not desired in such a piece of (critical) PAM infrastrucute. I guess it's up to the maintainer of libfprint to decide (Mailaender, fstrba, thoenig) if libfprint-2-2 should be provided by libfprint-tod sources.
Regards, Gryffus
Regards, Florian "sp1rit" -- $\int_\text{now}^{+\infty}\text{Keep trying}$ Matrix: @sp1rit:tchncs.de <sp1rit@disroot.org> D248BF2F4C6A82A1E0569D897D8C1CD573166D09 <sp1rit@national.shitposting.agency> BBDE032EAAFBFC627FB7E635B1F4055D8460CE34