2 Jun
2021
2 Jun
'21
02:47
On Tue, 01 Jun 2021 22:00:41 -0400 Neal Gompa <ngompa13@gmail.com> wrote:
We don't support filesystems without RENAME_EXCHANGE
I'm not sure what this ambiguous usage of the word "support" means, but for at least one interpretation, accepting my request would make this cease being true. In either case, on systems you *do* support, my patch does not modify the behavior, so it shouldn't matter to you, right?
this code makes the change not atomic and frankly quite scary.
Non-atomic rename is better than unbootable unrecoverable broken system.
Shouldn't you bug the OpenZFS people to implement renameat(2) instead?
I did: https://github.com/openzfs/zfs/issues/2256 OpenZFS not supporting this yet isn't a good reason to brick users' systems, IMO.