On Wed, Jun 12, 2013 at 05:50:43PM +0400, Andrey Borzenkov wrote:
<SNIP>
- please do not add new init scripts to factory. - the systemd service file : (comments inline
[Unit] Description=numad - The NUMA daemon that manages application locality.
After=syslog.target --> Not needed or used anymore, does nothing.
[Service] Type=forking
Can you make the service of type "simple" ? that is, a non-forking service ?
Actually I got this wrong. Even though the daemon does not receive socket connects and forks to handle each connection, numad does daemonize itself. If the service is of type simple then systemd does not start the process properly. I have two choices here. I can make it forking and specify the PidFile= or I can make it oneshot and specify RemainAfterExit=true. Which is preferred?
Of course PidFile is preferred in this case than lying about service state. This a at least will properly track daemon status.
Ok done and preliminary testing looks ok. The package should be up to date with all feedback. Is there anything else that should be fixed up? Any suggestions on what devel project to submit it to before pushing to factory? Thanks all for the review. -- Mel Gorman SUSE Labs -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org