On Dienstag, 1. Juni 2021, 20:05:43 CEST İsmail Dönmez wrote:
Hi Ludwig,
On Fri, May 28, 2021 at 4:10 PM Ludwig Nussel <ludwig.nussel@suse.de> wrote:
Hi,
tl;dr if you rely on package reviews for your development process in OBS make sure requests have a revision. Only osc shows the information you are looking for.
Turns out submit request in OBS do not necessarily refer to a specific revision in the originating package. Means the sources can change after a review passed. Unfortunately changing the sources does not reset reviews and reviews do not record the revision they were done for. That obviously defeats the purpose of source reviews. Accepting a request without revision may therefore lead to accepting something different from what was reviewed (resp staged).
Thanks for publicizing this issue, would it be possible to get a patch to disable this functionality? Doing this per-project basis sounds fine but for some OBS instances the alternative is never desired.
it also breaks functionality like submitting modified link information. One could enforce it always via an config/options.yml setting, but it has more consequences therefore. It was always communicated that it is up to the reviewer to decide if he wants to accept this or not (people should be used to this situation as it is also the default on platforms like github). It is nothing new since more then 10 years after all... -- Adrian Schroeter <adrian@suse.de> Build Infrastructure Project Manager SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany (HRB 247165, AG München), Geschäftsführer: Felix Imendörffer