On Fri, May 4, 2018 at 1:52 AM Thorsten Kukuk <kukuk@suse.de> wrote:
On Fri, May 04, Simon Lees wrote:
There are a couple of things here that should be discussed more broadly, 1. you seem to be packaging stuff into /snap which is outside the FHS guidelines, On fedora [1] they are using /var/lib/snapd/snap
Are this files in /var/lib/snapd included in the RPM filelist, or created at runtime? In the former case, /var is a really bad idea, as this contains variable data (FHS) and if you provide something with RPM, it's clearly static and will break snapshots, rollback and transactional-update.
They are snaps downloaded and managed at runtime. They are not static or included in the RPM file list.
2. Normally on openSUSE we don't allow packages to enable there service in %post in favor of the system administrator doing it, snap is a bit different from most standard services though so maybe its worth an exception but we should discuss that on this list.
If something should be enabled by default, it belongs to the systemd-preset-branding package for that product, never into the %pre/%post installs. There is really no valid reason to do or allow that.
openSUSE has the same %systemd_{preun,post,postun} macros that respect presets from upstream systemd, right? So the package can be changed to use those and whatever is needed to update the branding package can be done to enable the services. -- 真実はいつも一つ！/ Always, there's only one truth! -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org