On Wed, Jun 12, 2013 at 05:06:31PM +0200, Jan Engelhardt wrote:
On Wednesday 2013-06-12 16:43, Mel Gorman wrote:
Well, making the daemonization optional, perhaps through the use of a flag like smbd -F would allow you to use the simple ForkingType.
Unlike the other patches, that would be a fairly sizable deviation from upstream for opensuse. It would be a fairly straight-forward patch but is the forking type so bad that such a move is justified?
I had assumed you were upstream, apparently that is not the case.
No, I'm not a maintainer of upstream in this case.
Yes, it is "bad" - upstream should fix it ;-)
Obviously I can punt patches upstream and this one would be a candidate but I'm not sure what the reception will be. The upstream changelogs are monolithic patches with no documentation and very sporadic. If they take it, great. If not, I can carry it as numad is a very straight-forward program and I'm not expecting it to be much of a maintenance headache.
Redundant (even the venerable old startproc did the daemonization for the program), error-prone, archaic, etc.
Indeed. I've no idea what the original motivation was. Jollies maybe. I've updated the package now with the new patch and thanks for the review and pointing out the option. As before, suggestions on what devel project to submit this to before pushing to factory are welcome. -- Mel Gorman SUSE Labs -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org