On 10 May 2012 17:09, Vincent Untz <vuntz@opensuse.org> wrote:
Le jeudi 10 mai 2012, à 11:56 -0400, Cristian Rodríguez a écrit :
El 10/05/12 11:53, Vincent Untz escribió:
In general, I'm pretty much against non-upstream patches changing the build system unless there's a really good reason for them. Optimization is not a good enough reason for me: if the optimization matters.
The example optimization I mentioned first in the thread , also catches some extra buffer overflows.. is better security a good enough reason for you ?
Sounds like something we'd want to share with the world to me. So good reason, but reason to push upstream too :-)
Given Richard Guenther explanation I can't see a good way of upstreaming this. I mean, it's actually already upstreamed! The upstream patch is the -ansi/-std option that projects could use when developing, but that apparently nobody should be adding to the makefiles they release. Additionally gcc is a project with 19 patches already. So while I always try to avoid patches in my packages in this case I don't think a one line patch more or less is going to make any difference. In any case this is for gcc maintainers to decide. So I went forward and created the patch in home:RedDwarf:branches:devel:gcc. Any advice before creating a submit request? Should we run the testsuite with "SUSE_ALWAYS_GNU" defined or not? -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org