
Greetings everyone, I am the maintainer of server:messaging/telegram-desktop. I am sending this email to propose removing the libqt5-prioritise-gtk2-platformtheme.patch in the libqt5-qtbase repository. The link to the patch is https://build.opensuse.org/package/view_file/KDE:Qt:5.15/libqt5-qtbase/libqt.... The patch is used for prioritising gtk2 platform plugin in a Qt app, such that the Qt app integrates better with the outside GTK world. There is also a gtk3 platform plugin, but it just not working as good as the gtk2 one and it seems Qt doesn't have plan to fix it (https://bugreports.qt.io/browse/QTBUG-72506). I am proposing to obsolete this patch for the following reasons: First, this patch creates big problem in packaging and running Telegram Desktop on openSUSE GTK-based desktop environments, including GNOME, XFCE, and Cinammon. Basically, Telegram doesn't provide many features when using GTK2 platform plugin, such as system-native notifications, dark mode, and causing clipboard issues (https://github.com/telegramdesktop/tdesktop/blob/6635d03818c90f62cfddb516aca...). Because only openSUSE has this Qt patch, this problem doesn't exist on any other distribution. Second, all mainstream GTK-based desktop environments have migrated to GTK3. It doesn't make sense to keep prioritising the gtk2 platform plugin. Third, I think the problem mentioned in QTBUG-72506 could be fixed by letting the QGtk3Theme find the correct GTK3 theme in src/plugins/platformthemes/gtk3/qgtk3theme.cpp, which should be the right way to do things. Possible solutions: 1. Don't touch libqt5-qtbase and workaround only in telegram-desktop. This is the current solution. Currently we are using hacks to let Telegram run on qgtk2 platform plugin, which is unstable and could break anytime. 2. Remove libqt5-prioritise-gtk2-platformtheme.patch and don't do anything else. Telegram will be happy, but some Qt applications on GTK3 environments will not be able to correctly themed because of QTBUG-72506. I am not sure about this tho since I am a KDE user. 3. Remove libqt5-prioritise-gtk2-platformtheme.patch and patch GTK3 platform plugin instead I believe this is the right way to go, but it could break other things I am not aware of. Please let me know what you guys think. Thank you very much. Regards, Xu -- Xu Zhao i@xuzhao.net -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org