On 10/11/2013 07:32 AM, Roman Bysh wrote:
On 10/10/2013 11:59 PM, Cristian Rodríguez wrote:
El 11/10/13 00:49, Roman Bysh escribió:
On 10/10/2013 10:06 PM, Cristian Rodríguez wrote:
That is great news! It's interesting how a previous patch applied a number of years ago to the kernel broke the newer binary blobs.
???? The chamge that broke the driver was only added in 3.12rc.. not years ago.
Oops! I was looking at the originating date of: Mon Sep 17 00:00:00 2001
Please note that the following open-source licensed code was moved from files bus.c to scan.c in the Linux open-source kernel.
The scan.c file already contained the entry:
<--------- snip -------------------------------< int acpi_device_add(struct acpi_device *device, void (*release)(struct device *)) <--------- snip -------------------------------<
But was missing:
<------------ snip ----------------------------------------------------< int acpi_bus_get_device(acpi_handle handle, struct acpi_device **device) } return 0; }
EXPORT_SYMBOL_GPL(acpi_bus_get_device); <------------ snip ----------------------------------------------------<
Hence the patch. Follow Up
<------------- snipped from the original email -------------- Subject: ACPI: Use EXPORT_SYMBOL() for acpi_bus_get_device() Commit (ACPI: Move acpi_bus_get_device() from bus.c to scan.c) caused acpi_bus_get_device() to be exported using EXPORT_SYMBOL_GPL(), but that broke some binary drivers in existence, so revert that change. -- Cheers! Roman -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org