Takashi Iwai wrote:
At Fri, 26 Jun 2015 23:01:27 +0200, Carlos E. R. wrote:
On 2015-06-26 21:42, Takashi Iwai wrote:
Ah right. But the argument is same. If we have something like $SUSPEND_MODULE in /etc/sysconfig/suspend, it's easier to manage, for example.
The OP said that these should be reported in bugzillas against the kernel. But this can take weeks, months, even years! Thus, till whatever kernel piece is corrected, we, as users, still need (temporary) hacks.
Yes, that's exactly my intention, too.
As a long time person who has been involved with kernel development, I highly appreciate bug reports. It's the first thing we care. OTOH, I see no big reason to make workarounds difficult.
A possible compromise would be to let the script give some warning if it actually unloads/reloads the module.
Following work-around will not work? /usr/lib/systemd/system-sleep/broken-modules.sh #!/bin/bash . /etc/sysconfig/suspend if [ "$1" = pre ] && ( [ "$2" = hibernate ] || [ "$2" = hybrid-sleep ] ) ; then for MODULE in $SUSPEND_MODULE ; do rmmod $MODULE done fi if [ "$1" = post ] && ( [ "$2" = hibernate ] || [ "$2" = hybrid-sleep ] ) ; then for MODULE in $SUSPEND_MODULE ; do modprobe $MODULE done fi -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com Lihovarská 1060/12 tel: +49 911 7405384547 190 00 Praha 9 fax: +420 284 084 001 Czech Republic http://www.suse.cz/ PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76 -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org