On 04/26/2017 09:08 AM, Greg Freemyer wrote:
On Tue, Apr 25, 2017 at 7:10 PM, Simon Lees <sflees@suse.de> wrote:
On 04/26/2017 08:00 AM, Greg Freemyer wrote:
I'm going to treat that as a given and I think that is all the board has spoken to so far.
But we have %suse_version, %sle_version, %leap_version, and %is_opensuse.
In Leap 42.2 they are:
suse_version = 1315 sle_version = 120200 leap_version = 420200 is_opensuse = 1
In Leap Next, if I understand correctly, we may kill off leap_version and only have:
suse_version = 1500 sle_version = 150000 is_opensuse = 1
Is it really all that painful to also have:
leap_version = 450000 or leap_version = 1500000 (note the extra zero)
And if having both sle_version and leap_version different really is that painful, why not make both 1500000
sle_version = 1500000 (with the extra zero) leap_version = 1500000 (with the extra zero)
Most uses i've seen using leap_version, are working around specific issues / patches for Leap 42.X as Leap 15.X will be branched freshly the number of cases where leap_version is applicable / still needed currently should be minimal, in most cases the current correct condition for Leap 15.X is still suse_version > 1320, and we will only need another conditional once 15.X has been branched properly and we need to distinguish between that and tumbleweed again for whatever reason.
Sounds like step 1 is going to be to go through all of OBS and eliminate use of leap_version.
Almost none of the 100 or so packages I maintain for Leap are in SLE.
The majority are in security:forensics. What's the osc command to cat out all the spec files in there so I can look for uses of leap_version? I may not even use it currently.
I don't remember the specific command but as long as the packages also build for tumbleweed where we don't have it set you won't need to do anything, once Leap 42.X is out of support (remembering we still have a release to go), then you may choose to go through and clean up the dead code but it won't cause any issues keeping the conditions there as long as those conditions are specific to leap. -- Simon Lees (Simotek) http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B