On Fri, Dec 13, 2019 at 08:50, Stefan Seyfried <stefan.seyfried@googlemail.com> wrote:
Hi all,
I wanted to fix the arandr factory failure which is caused by:
[ 4s] calling /usr/lib/rpm/brp-suse.d/brp-30-desktop [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/suse-screensavers.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/applications-kmenuedit.menu' does not exist [ 5s] WARNING: '/usr/lib/rpm/brp-desktop.data/custom.menu' does not exist [ 5s] ERROR: Icon file not installed: /home/abuild/rpmbuild/BUILDROOT/arandr-0.1.10-0.x86_64//usr/share/applications/arandr.desktop (package_utility_desktop) [ 5s] Errors in installed desktop file detected. Please refer to http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros
(the http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros section on %suse_update_desktop_file does not help).
The problem is, that arandr.desktop contains "icon=desktop" and there is no desktop icon installed in the build system.
Do I have to depend on an icon theme (which one?) for a successfull build?
Is this a good idea? I doubt so.
In general, it's best to use one of many default icon names, because they are mostly guaranteed to exist within the themes, if you aren't willing to have own icon for it https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-lat...
Anyway, i tried with tango-icon-theme (because it has no other dependencies) and adwaita-icon-theme (which pull in 30 more GTK packages...) and it did not help.
If I recall correctly, it only checks build environment, so BuildRequires with an icon theme is enough
Is the check simply buggy?
Yes, there is a good reason this PR exists https://github.com/openSUSE/brp-check-suse/pull/14 LCP [Stasiek] https://lcp.world -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org