Am Dienstag, 3. Mai 2011, 19:24:35 schrieb Cristian Morales Vega:
2011/5/3 Stephan Kulow <coolo@novell.com>:
Am Dienstag, 3. Mai 2011 schrieb Cristian Morales Vega:
2011/5/3 Stephan Kulow <coolo@novell.com>:
After a series of broken packages because of _service files I would like to forbid them in openSUSE:Factory.
So far I've seen the use of _service files in factory as an experiment (I happily joined), but I see this experiment as failed.
As a happy _service files user I would object... unless I would know more about "a series of broken packages". See Vincent's mail this morning - this was not even the last one.
It looks like a minor problem, either it's a big download or you must be really fast to create a SR before the service has completed. And it should be simple enough to solve. In fact it's already solved in the client side. I don't look every day at Factory build errors, you know better than me the number and severity of the problems. But from my corner it seems right now _service files create nearly zero problems, I could be wrong...
I still want to solve open problems at least ;) However, the new way coolo suggested can be implemented via project wide source service. The download_url service can be replaced by a project wide download_files service. It would download the files according to spec file URL. combining this with new osc and "trylocal" option it would offer both ways, submitting the downloaded tar ball together with the submission and let the server just validated. Or trigger it to server side download when bandwidth problems exist for packagers with packages with large tar balls. However, I still see the need to allow to run tar_scm. At least manually created tar balls would be a step backward IMHO.
Sure, I had a problem recently. But it was a lot worse before, things have been improving a lot for me. What packages in factory do you have with _service files and what do they use?
Which I consider mine: libgme, libebml, libmatroska and mkvtoolnix. All of them use download_url, verify_file and set_version. I don't remember having a problem with them ever. They are not the packages that could benefit the most from services, but it still makes life easier when someone submit requests me an upstream update to the devel project.
- instead we verify the Source urls and make packages that have invalid URLs "broken", so you can't SR them to factory.
What do you mean with "verify"? If you mean verify the URL is not malformed, I don't think that would be really useful. If you mean use wget/curl on it, and check the submitted and downloaded tarballs match... well, that's what _service files do now. I mean to wget/curl them and check that it's the same as in the package and not something unrelated, but the source tar would stay in the package and wouldn't be regenerated/recommited on every source change. People clearly expect a osc commit after a working local build to also work on the server.
And this isn't exactly what download_url and verify_file are doing now? You want to change the current services for a different implementation that does exactly the same?? I will expect a new implementation to be buggier.
it would be also a source service implementation but using the project wide services. I planned to write something more informative about this, so far there is only our book chapter: http://doc.opensuse.org/products/draft/OBS/obs-reference-guide_draft/cha.obs... -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org