On Friday 21 March 2014, Stanislav Brabec wrote:
Ruediger Meier wrote:
Hi,
The ChangeLog is almost useless since none of the referenced bug reports is readable for non-suse people.
These changelogs were taken from the original changelog. Many of openSUSE changelogs refer to bugs that are not accessible. In ideal case, people working on SLES fix would post the same patch to openSUSE, and make a public clone of the bug report. It did not happened, and a review found these patches, where the patch was not posted to Factory nor upstream.
At least one of the added patches ("umount-avoid-readlink.patch") has no effect because it patches a deprecated and unused subdir which will be removed in next release anyway.
Yes, it is deliberate. The patch was created for SLE11 and affects the code, which is now deprecated and not used. I did not want to lose this patch and save it for upstreaming.
Upstream has already removed the whole code.
Collecting upstream-able patches will take some time. Hopefully these patches will disappear from the Factory then.
I'd like to help to get useful patches upstream. But it's hard if I'm not allowed to know anything about the fixed issues.
Please somebody have a look at the last changelog and either make the bug reports world-readable or fix the changlog to explain the purpose of these patches:
SLES bug reports that contain sensitive customer data cannot be opened for public.
Have you really checked all the bug reports and they all contain sensitive data?
Most of these patches are self descriptive. Well, this one is probably not true for umount-avoid-readlink.patch:
It's purpose is avoiding a readlink() failure when umount'ing stale NFS volumes.
But today your patch only changes unused code. If this is still an issue in the new code then your patch will not fix it. Volunteer reviewers (like me) cannot really check if there is still an issue or not. Also I'd like to check whether this patch would be good for Evergreen 11.4.
* lscpu: improve hypervisor detection (puzel@novell.com, fate#310255)
This patch for example breaks a test in the test suite. None of us can read the discussion about this new feature. non-SLE people had no chance to say their opinion about it. cu, Rudi -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org