On Thu, 2020-04-30 at 14:00 +0000, Martin Wilck wrote:
Are you saying that factory reviewers would look at every single patch and try to figure out if it's correct? In my experience, factory review is focused on formal aspects of rpm building, the spec file and the changelog. Which is fine on that level.
It's mostly on formal level, yet we also look at patches and every now and then even spot something obviously wrong. It's just a pair of eyes more looking at it.
Review of individual patches for given software packages are the package maintainer's task. Package maintainers are likely to work with git or some other VC system on their package anyway, and if they are, they are served better by the VC than by the patch listing in the spec file.
Considering that the review team every now and then still declines patches that are obviously wrong: what does that tell us about the maintainers? They're human. They can make errors. Luckily, this is not the common case. But having the patches visible does help. Cheers, Dominique