On Fri, Mar 20, 2009 at 12:59:00PM +0100, Pavol Rusnak wrote:

Petr Uzel wrote:

...

However, I've declined your package because of the build warnings. You could apply attached patch that fixes them and resubmit the request.

You should never add X-SuSE-Translate to desktop file by hand. It is added with %suse_update_desktop_file (and thus could appear twice in the resulting file). Also Encoding parameter is deprecated as all desktop files use UTF-8 now. Finally, don't put fullpath or extension to Icon. DE will find the icon anyway and you don't have to change the path/extension in case the packaging changes.

Thanks for correcting me (and the patch). It seems that http://en.opensuse.org/SUSE_Package_Conventions/Desktop_Menu is terribly outdated :( -- Best regards / s pozdravem Petr Uzel, Packages maintainer --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: puzel@suse.cz Lihovarská 1060/12 tel: +420 284 028 964 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org