Hello community, here is the log from the commit of package hal checked in at Wed Jun 21 17:54:40 CEST 2006. -------- --- hal/hal.changes 2006-06-12 06:23:37.000000000 +0200 +++ hal/hal.changes 2006-06-18 21:36:50.000000000 +0200 @@ -1,0 +2,9 @@ +Sun Jun 18 21:05:48 CEST 2006 - dkukawka@suse.de + +- added patch: + - hal-fix-memoryleak_libhal-storage_185032.diff: fixed bug + #185032 to close memory leaks in libhal-storage. Changed libhal + *_free() functions to set pointer to NULL after freed the + pointer. + +------------------------------------------------------------------- New: ---- hal-fix-memoryleak_libhal-storage_185032.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ hal.spec ++++++ --- /var/tmp/diff_new_pack.qcGzt4/_old 2006-06-21 17:54:23.000000000 +0200 +++ /var/tmp/diff_new_pack.qcGzt4/_new 2006-06-21 17:54:23.000000000 +0200 @@ -19,7 +19,7 @@ License: Other License(s), see package, Other uncritical OpenSource License Group: System/Daemons Version: 0.5.6 -Release: 36 +Release: 37 Autoreqprov: on Summary: Daemon for Collecting Hardware Information # SUSE specific patches @@ -55,6 +55,7 @@ Patch116: hal-add-debug_to_syslog_probing_v2.diff Patch117: hal-fix-probe_smbios_parse_bug172204.diff Patch118: hal-fix_workaround_libhal-strage_get_volume_size.diff +Patch119: hal-fix-memoryleak_libhal-storage_185032.diff # external patches from HAL List and backports Patch200: hal-add-scsi-type.diff Patch201: hal-fix-SG_IO_bug145147.diff @@ -191,6 +192,7 @@ %patch208 %patch10 %patch11 +%patch119 #%patch300 #rm -rf py-compile 4> /dev/null || : #ln -s /usr/share/automake-1.9/py-compile py-compile 2> /dev/null || : @@ -306,6 +308,12 @@ %{_bindir}/hal-device-manager %changelog -n hal +* Sun Jun 18 2006 - dkukawka@suse.de +- added patch: +- hal-fix-memoryleak_libhal-storage_185032.diff: fixed bug + [#185032] to close memory leaks in libhal-storage. Changed libhal + *_free() functions to set pointer to NULL after freed the + pointer. * Mon Jun 12 2006 - dkukawka@suse.de - added patch: - hal-fix-umount-pcmcia_storage_devices.diff: fixed bug #181557 ++++++ hal-fix-memoryleak_libhal-storage_185032.diff ++++++ --- libhal-storage/libhal-storage.c 2006-06-16 23:51:31.000000000 +0200 +++ libhal-storage/libhal-storage.c 2006-06-17 00:17:44.000000000 +0200 @@ -749,6 +749,8 @@ libhal_free_string (drive->model); libhal_free_string (drive->type_textual); libhal_free_string (drive->physical_device); + libhal_free_string (drive->dedicated_icon_drive); + libhal_free_string (drive->dedicated_icon_volume); libhal_free_string (drive->serial); libhal_free_string (drive->firmware_version); libhal_free_string (drive->desired_mount_point); @@ -778,7 +780,8 @@ libhal_free_string (vol->uuid); libhal_free_string (vol->desired_mount_point); libhal_free_string (vol->mount_filesystem); - + libhal_free_string (vol->storage_device); + free (vol); } --- libhal/libhal.c 2006-06-16 23:51:31.000000000 +0200 +++ libhal/libhal.c 2006-06-16 17:55:42.000000000 +0200 @@ -80,8 +80,10 @@ for (i = 0; str_array[i] != NULL; i++) { free (str_array[i]); + str_array[i] = NULL; } free (str_array); + str_array = NULL; } } @@ -151,7 +153,10 @@ libhal_free_string (char *str) { /** @todo implement for UTF8 */ - free (str); + if (str != 0) { + free (str); + str = NULL; + } } ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit-unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit-help@opensuse.org