Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package monitoring-plugins-smart for openSUSE:Factory checked in at 2023-09-28 00:26:20 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/monitoring-plugins-smart (Old) and /work/SRC/openSUSE:Factory/.monitoring-plugins-smart.new.23327 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "monitoring-plugins-smart" Thu Sep 28 00:26:20 2023 rev:11 rq:1113908 version:6.14.1 Changes: -------- --- /work/SRC/openSUSE:Factory/monitoring-plugins-smart/monitoring-plugins-smart.changes 2023-05-13 18:14:55.640817349 +0200 +++ /work/SRC/openSUSE:Factory/.monitoring-plugins-smart.new.23327/monitoring-plugins-smart.changes 2023-09-28 00:39:00.978027855 +0200 @@ -1,0 +2,11 @@ +Wed Sep 20 13:57:46 UTC 2023 - lars@linux-schulserver.de - 6.14.1 + +- update to 6.14.1 + + Fix default Percent_Lifetime_Remain threshold handling when -w + is given by @ymartin-ovh , see #93 + + Fix debug output of raw check list when using -l or + ssd-lifetime, see #94 + + Fix --hide-sn when combined with --debug (the smartctl output + still showed the serial number), see #94 + +------------------------------------------------------------------- Old: ---- check_smart-6.14.0.tar.xz New: ---- check_smart-6.14.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ monitoring-plugins-smart.spec ++++++ --- /var/tmp/diff_new_pack.o7tVIT/_old 2023-09-28 00:39:02.162070925 +0200 +++ /var/tmp/diff_new_pack.o7tVIT/_new 2023-09-28 00:39:02.162070925 +0200 @@ -17,7 +17,7 @@ Name: monitoring-plugins-smart -Version: 6.14.0 +Version: 6.14.1 Release: 0 Summary: Check SMART status of a given disk License: GPL-3.0-or-later ++++++ check_smart-6.14.0.tar.xz -> check_smart-6.14.1.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/check_smart-6.14.0/check_smart.pl new/check_smart-6.14.1/check_smart.pl --- old/check_smart-6.14.0/check_smart.pl 2023-04-29 11:40:58.000000000 +0200 +++ new/check_smart-6.14.1/check_smart.pl 2023-09-20 14:50:07.000000000 +0200 @@ -58,13 +58,15 @@ # Apr 29, 2023: Nick Bertrand - Show drive(s) causing UNKNOWN status using -g/--global check (6.14.0) # Apr 29, 2023: Claudio Kuenzler - Add possibility to hide serial number (--hide-sn) (6.14.0) # Apr 29, 2023: Claudio Kuenzler - Add default check on Load Cycle Count (ignore using --skip-load-cycles) (6.14.0) +# Sep 20, 2023: Yannick Martin - Fix default Percent_Lifetime_Remain threshold handling when -w is given (6.14.1) +# Sep 20, 2023: Claudio Kuenzler - Fix debug output for raw check list, fix --hide-serial in debug output (6.14.1) use strict; use Getopt::Long; use File::Basename qw(basename); my $basename = basename($0); -my $revision = '6.14.0'; +my $revision = '6.14.1'; # Standard Nagios return codes my %ERRORS=('OK'=>0,'WARNING'=>1,'CRITICAL'=>2,'UNKNOWN'=>3,'DEPENDENT'=>4); @@ -228,7 +230,6 @@ # warning threshold list (for raw checks) my $warn_list = $opt_w // ''; -$warn_list = $opt_w // 'Percent_Lifetime_Remain=90' if $opt_l; my @warn_list = split /,/, $warn_list; my %warn_list; my $warn_key; @@ -237,6 +238,9 @@ ($warn_key, $warn_value) = split /=/, $warn_element; $warn_list{ $warn_key } = $warn_value; } +if ($opt_l && ! exists $warn_list{'Percent_Lifetime_Remain'}) { + $warn_list{'Percent_Lifetime_Remain'} = 90; +} # For backward compatibility, add -b parameter to warning thresholds if ($opt_b) { @@ -280,6 +284,7 @@ warn "###########################################################\n\n\n" if $opt_debug; my $full_command = "$smart_command -d $interface -Hi $device"; + $full_command = "$smart_command -d $interface -Hi $device -q noserial" if $opt_hide_sn; warn "(debug) executing:\n$full_command\n\n" if $opt_debug; my @output = `$full_command`; @@ -470,7 +475,7 @@ @output = `$full_command`; warn "(debug) output:\n@output\n\n" if $opt_debug; my @perfdata = qw//; - warn "(debug) Raw Check List ATA: $raw_check_list\n" if $opt_debug; + warn "(debug) Raw Check List ATA: @raw_check_list\n" if $opt_debug; warn "(debug) Raw Check List NVMe: $raw_check_list_nvme\n" if $opt_debug; warn "(debug) Exclude List for Checks: ", join(",", @exclude_checks), "\n" if $opt_debug; warn "(debug) Exclude List for Perfdata: ", join(",", @exclude_perfdata), "\n" if $opt_debug; @@ -834,7 +839,7 @@ sub print_help { print_revision($basename,$revision); - print "\nUsage: $basename {-d=<block device>|-g=<block device glob>} -i=(auto|ata|scsi|3ware,N|areca,N|hpt,L/M/N|aacraid,H,L,ID|cciss,N|megaraid,N) [-r list] [-w list] [-b N] [-e list] [-E list] [--debug]\n\n"; + print "\nUsage: $basename {-d=<block device>|-g=<block device glob>} -i=(auto|ata|scsi|3ware,N|areca,N|hpt,L/M/N|aacraid,H,L,ID|cciss,N|megaraid,N) [-r list] [-w list] [-b N] [-e list] [-E list] [-s] [-l] [--debug]\n\n"; print "At least one of the below. -d supersedes -g\n"; print " -d/--device: a physical block device to be SMART monitored, eg /dev/sda. Pseudo-device /dev/bus/N is allowed.\n"; print " -g/--global: a glob pattern name of physical devices to be SMART monitored\n";