Hello community,
here is the log from the commit of package yast2-core for openSUSE:Factory checked in at 2012-02-06 16:41:21
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-core (Old)
and /work/SRC/openSUSE:Factory/.yast2-core.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-core", Maintainer is "mvidner@suse.com"
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-core/yast2-core.changes 2012-01-09 12:55:47.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.yast2-core.new/yast2-core.changes 2012-02-06 16:41:22.000000000 +0100
@@ -1,0 +2,6 @@
+Fri Feb 3 14:36:31 CET 2012 - mvidner@suse.cz
+
+- ini-agent: only change permissions of new files (bnc#743355)
+- 2.22.3
+
+-------------------------------------------------------------------
Old:
----
yast2-core-2.22.2.tar.bz2
New:
----
yast2-core-2.22.3.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-core.spec ++++++
--- /var/tmp/diff_new_pack.ftvmZp/_old 2012-02-06 16:41:26.000000000 +0100
+++ /var/tmp/diff_new_pack.ftvmZp/_new 2012-02-06 16:41:26.000000000 +0100
@@ -16,20 +16,20 @@
#
-
Name: yast2-core
-Version: 2.22.2
+Version: 2.22.3
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Source0: yast2-core-%{version}.tar.bz2
-Group: System/YaST
-License: GPL-2.0+
# obviously
-BuildRequires: boost-devel gcc-c++ libtool
+BuildRequires: boost-devel
+BuildRequires: gcc-c++
+BuildRequires: libtool
# we have a parser
-BuildRequires: bison flex
+BuildRequires: bison
+BuildRequires: flex
# needed for all yast packages
BuildRequires: yast2-devtools
# testsuite
@@ -37,7 +37,8 @@
# autodocs
BuildRequires: doxygen
# docbook docs
-BuildRequires: docbook-xsl-stylesheets libxslt
+BuildRequires: docbook-xsl-stylesheets
+BuildRequires: libxslt
# catalog: convert URIs to local filenames
BuildRequires: sgml-skel
# logging
@@ -47,6 +48,8 @@
BuildRequires: libxcrypt-devel
Summary: YaST2 - Core Libraries
+License: GPL-2.0+
+Group: System/YaST
Requires: perl = %{perl_version}
Provides: liby2util = 2.16.1
Obsoletes: liby2util < 2.16.1
@@ -59,6 +62,7 @@
Requires: yast2-core = %version
Summary: YaST2 - Core Libraries
+Group: System/YaST
Provides: liby2util-devel = 2.16.1
Obsoletes: liby2util-devel < 2.16.1
Requires: libxcrypt-devel hwinfo-devel
@@ -74,8 +78,8 @@
%package debugger
Requires: yast2-core = %version
-Group: Development/Libraries
Summary: YaST2 - Core Libraries
+Group: Development/Libraries
%description debugger
YCP debugger client.
++++++ yast2-core-2.22.2.tar.bz2 -> yast2-core-2.22.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/VERSION new/yast2-core-2.22.3/VERSION
--- old/yast2-core-2.22.2/VERSION 2012-01-06 15:22:51.000000000 +0100
+++ new/yast2-core-2.22.3/VERSION 2012-02-03 17:00:53.000000000 +0100
@@ -1 +1 @@
-2.22.2
+2.22.3
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/agent-ini/src/IniParser.cc new/yast2-core-2.22.3/agent-ini/src/IniParser.cc
--- old/yast2-core-2.22.2/agent-ini/src/IniParser.cc 2012-01-06 15:22:50.000000000 +0100
+++ new/yast2-core-2.22.3/agent-ini/src/IniParser.cc 2012-02-03 17:00:53.000000000 +0100
@@ -8,7 +8,7 @@
* Petr Blahos
* Martin Vidner
*
- * $Id: IniParser.cc 67117 2012-01-05 17:03:40Z mvidner $
+ * $Id: IniParser.cc 67361 2012-02-03 15:55:59Z mvidner $
*/
#include "config.h"
@@ -1000,8 +1000,6 @@
mode_t file_umask = section.isPrivate()? 0077: 0022;
mode_t orig_umask = umask(file_umask);
- // rewriting an existing file wouldnt change its mode
- unlink(filename.c_str());
ofstream of(filename.c_str());
if (!of.good()) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.err new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.err
--- old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.err 2012-01-06 15:22:51.000000000 +0100
+++ new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.err 2012-02-03 17:00:53.000000000 +0100
@@ -1,11 +1,45 @@
+[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.0.test to 0
[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.1.test to 1
[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.2.test to 2
-[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."1"."Totalise"."Password" = "Secret password"
-[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."2"."arcor"."Password" = "Public password"
+[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.3.test to 3
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."0".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."0".Section.Key = "existing public implicit"
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."1".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."1".Section.Key = "existing public explicit"
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."2".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."2".Section.Key = "existing private implicit"
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."3".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."3".Section.Key = "existing private explicit"
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively 4 to .v."4".Section.Key
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."4".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."4".Section.Key = "new public implicit"
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively 5 to .v."5".Section.Key
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."5".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."5".Section.Key = "new public explicit"
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively 6 to .v."6".Section.Key
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."6".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."6".Section.Key = "new private implicit"
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively 7 to .v."7".Section.Key
+[agent-ini] IniFile.cc(setValue):XXX Write: adding recursively Section to .v."7".Section.Key
+[agent-ini] IniFile.cc(setMyValue):XXX Adding value .v."7".Section.Key = "new private explicit"
+[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.0.test to 0
[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.1.test to 1
[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.2.test to 2
+[agent-ini] IniParser.cc(parse):XXX Rewriting multi/private.in.3.test to 3
+[agent-ini] IniParser.cc(getFileName):XXX Rewriting 0 to multi/private.in.0.test
[agent-ini] IniParser.cc(getFileName):XXX Rewriting 1 to multi/private.in.1.test
[agent-ini] IniParser.cc(getFileName):XXX Rewriting 2 to multi/private.in.2.test
-[YCP] multi/private.ycp:XXX secret file mode: $["exit":0, "stderr":"", "stdout":"600\n"]
-[YCP] multi/private.ycp:XXX public file mode: $["exit":0, "stderr":"", "stdout":"644\n"]
+[agent-ini] IniParser.cc(getFileName):XXX Rewriting 3 to multi/private.in.3.test
+[agent-ini] IniParser.cc(getFileName):XXX Rewriting 4 to multi/private.in.4.test
+[agent-ini] IniParser.cc(getFileName):XXX Rewriting 5 to multi/private.in.5.test
+[agent-ini] IniParser.cc(getFileName):XXX Rewriting 6 to multi/private.in.6.test
+[agent-ini] IniParser.cc(getFileName):XXX Rewriting 7 to multi/private.in.7.test
+[YCP] multi/private.ycp:XXX existing public implicit file mode: 644
+[YCP] multi/private.ycp:XXX existing public explicit file mode: 644
+[YCP] multi/private.ycp:XXX existing private implicit file mode: 600
+[YCP] multi/private.ycp:XXX existing private explicit file mode: 600
+[YCP] multi/private.ycp:XXX new public implicit file mode: 644
+[YCP] multi/private.ycp:XXX new public explicit file mode: 644
+[YCP] multi/private.ycp:XXX new private implicit file mode: 644
+[YCP] multi/private.ycp:XXX new private explicit file mode: 600
[agent-ini] IniParser.cc(write):XXX File multi/private.in.*.test did not change. Not saving.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.in.1 new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.in.1
--- old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.in.1 2012-01-06 15:22:51.000000000 +0100
+++ new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.in.1 2012-02-03 17:00:53.000000000 +0100
@@ -1,10 +0,0 @@
-[Dialer Totalise]
-Compuserve = 0
-Provider = Totalise
-Phone = 08453001470
-[End]
-
-[Dialer force9]
-Provider = Force9
-Phone = 08451424000
-[End]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.in.2 new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.in.2
--- old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.in.2 2012-01-06 15:22:51.000000000 +0100
+++ new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.in.2 2012-02-03 17:00:53.000000000 +0100
@@ -1,11 +0,0 @@
-[Dialer arcor]
-Compuserve = 0
-Provider = Arcor
-[End]
-
-[Dialer mobilcom]
-Compuserve = 0
-Provider = Mobilcom
-Phone = 0101901929
-[End]
-
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.out new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.out
--- old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.out 2012-01-06 15:22:51.000000000 +0100
+++ new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.out 2012-02-03 17:00:53.000000000 +0100
@@ -1,25 +1,25 @@
(nil)
+multi/private.in.0.test -------------------------------
+[Section]
+Key = existing public implicit
multi/private.in.1.test -------------------------------
-[Dialer Totalise]
- Compuserve = 0
- Provider = Totalise
- Phone = 08453001470
- Password = Secret password
-[End]
-
-[Dialer force9]
- Provider = Force9
- Phone = 08451424000
-[End]
+[Section]
+Key = existing public explicit
multi/private.in.2.test -------------------------------
-[Dialer arcor]
- Compuserve = 0
- Provider = Arcor
- Password = Public password
-[End]
-
-[Dialer mobilcom]
- Compuserve = 0
- Provider = Mobilcom
- Phone = 0101901929
-[End]
+[Section]
+Key = existing private implicit
+multi/private.in.3.test -------------------------------
+[Section]
+Key = existing private explicit
+multi/private.in.4.test -------------------------------
+[Section]
+Key = new public implicit
+multi/private.in.5.test -------------------------------
+[Section]
+Key = new public explicit
+multi/private.in.6.test -------------------------------
+[Section]
+Key = new private implicit
+multi/private.in.7.test -------------------------------
+[Section]
+Key = new private explicit
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.scr new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.scr
--- old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.scr 2012-01-06 15:22:51.000000000 +0100
+++ new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.scr 2012-02-03 17:00:53.000000000 +0100
@@ -6,12 +6,11 @@
"rewrite" : [
[ "multi/private\.in\.(.)\.test$", "multi/private.in.%s.test"],
],
- "subindent" : " ",
+ "subindent" : "",
"comments": [ "^[ \t]*#.*", "^[ \t]*$" ],
"sections" : [
$[
- "begin" : [ "[ \t]*\\[Dialer[ \t]+(.*[^ \t])[ \t]*\\][ \t]*", "[Dialer %s]" ],
- "end" : [ "^[ \t]*\\[End\\][ \t]*$", "[End]", ],
+ "begin" : [ "[ \t]*\\[(.*[^ \t])[ \t]*\\][ \t]*", "[%s]" ],
],
],
"params" : [
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.ycp new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.ycp
--- old/yast2-core-2.22.2/agent-ini/testsuite/multi/private.ycp 2012-01-06 15:22:51.000000000 +0100
+++ new/yast2-core-2.22.3/agent-ini/testsuite/multi/private.ycp 2012-02-03 17:00:53.000000000 +0100
@@ -1,26 +1,49 @@
-//
-// Multiple files test
-//
-// providers.rpm
-//
-
+// test private files, bnc#743355
{
SCR::RegisterAgent (.target, `ag_system ());
- any out = nil;
-
- SCR::Write (.v."1"."Totalise"."Password", "Secret password");
- SCR::Write (.section_private."1", true);
-
- SCR::Write (.v."2"."arcor"."Password", "Public password");
+ // 8 combinations to test
+ // bitmask:
+ // 4: new file, 0: existing file
+ // 2: secret 0: public
+ // 1: explicit with section_private 0: implicit with permisions of existing file
+
+ // #2, existing private implicit, was the one reported about sssd.conf
+ // #6, new private implicit, is a contradiciton in requirements, XFAIL
+
+ string description(integer i) {
+ string new_s = ((i & 4) != 0)?
+ "new ":
+ "existing ";
+ string private_s = ((i & 2) != 0)?
+ "private ":
+ "public ";
+ string explicit_s = ((i & 1) != 0)?
+ "explicit":
+ "implicit";
+ return new_s + private_s + explicit_s;
+ }
+
+ // fix permissions of fixtures from svn/git
+ foreach(integer i, [2, 3], {
+ SCR::Execute (.target.bash, sformat("chmod 600 multi/private.in.%1.test", i));
+ });
+
+ foreach(integer i, [0, 1, 2, 3, 4, 5, 6, 7], {
+ string i_str = tostring(i);
+ SCR::Write (add(add(.v, i_str), .Section.Key), description(i));
+
+ if ((i & 1) != 0) {
+ SCR::Write (add(.section_private, i_str), (i & 2) != 0);
+ }
+ });
SCR::Write (., nil); //flush
- out = SCR::Execute (.target.bash_output, "stat -c %a multi/private.in.1.test");
- y2milestone("secret file mode: %1", out);
-
- out = SCR::Execute (.target.bash_output, "stat -c %a multi/private.in.2.test");
- y2milestone("public file mode: %1", out);
+ foreach(integer i, [0, 1, 2, 3, 4, 5, 6, 7], {
+ map out = (map) SCR::Execute (.target.bash_output, sformat("stat -c %%a multi/private.in.%1.test", i));
+ y2milestone("%1 file mode: %2", description(i), out["stdout"]:"");
+ });
return nil;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/configure new/yast2-core-2.22.3/configure
--- old/yast2-core-2.22.2/configure 2012-01-06 15:23:04.000000000 +0100
+++ new/yast2-core-2.22.3/configure 2012-02-03 17:01:06.000000000 +0100
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.68 for yast2-core 2.22.2.
+# Generated by GNU Autoconf 2.68 for yast2-core 2.22.3.
#
# Report bugs to http://bugs.opensuse.org/.
#
@@ -570,8 +570,8 @@
# Identity of this package.
PACKAGE_NAME='yast2-core'
PACKAGE_TARNAME='yast2-core'
-PACKAGE_VERSION='2.22.2'
-PACKAGE_STRING='yast2-core 2.22.2'
+PACKAGE_VERSION='2.22.3'
+PACKAGE_STRING='yast2-core 2.22.3'
PACKAGE_BUGREPORT='http://bugs.opensuse.org/'
PACKAGE_URL=''
@@ -1371,7 +1371,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures yast2-core 2.22.2 to adapt to many kinds of systems.
+\`configure' configures yast2-core 2.22.3 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1442,7 +1442,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of yast2-core 2.22.2:";;
+ short | recursive ) echo "Configuration of yast2-core 2.22.3:";;
esac
cat <<\_ACEOF
@@ -1559,7 +1559,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-yast2-core configure 2.22.2
+yast2-core configure 2.22.3
generated by GNU Autoconf 2.68
Copyright (C) 2010 Free Software Foundation, Inc.
@@ -2103,7 +2103,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by yast2-core $as_me 2.22.2, which was
+It was created by yast2-core $as_me 2.22.3, which was
generated by GNU Autoconf 2.68. Invocation command line was
$ $0 $@
@@ -3033,7 +3033,7 @@
# Define the identity of the package.
PACKAGE='yast2-core'
- VERSION='2.22.2'
+ VERSION='2.22.3'
cat >>confdefs.h <<_ACEOF
@@ -3155,7 +3155,7 @@
-VERSION="2.22.2"
+VERSION="2.22.3"
RPMNAME="yast2-core"
MAINTAINER="Martin Vidner "
@@ -18481,7 +18481,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by yast2-core $as_me 2.22.2, which was
+This file was extended by yast2-core $as_me 2.22.3, which was
generated by GNU Autoconf 2.68. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -18547,7 +18547,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
ac_cs_version="\\
-yast2-core config.status 2.22.2
+yast2-core config.status 2.22.3
configured by $0, generated by GNU Autoconf 2.68,
with options \\"\$ac_cs_config\\"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-core-2.22.2/configure.in new/yast2-core-2.22.3/configure.in
--- old/yast2-core-2.22.2/configure.in 2012-01-06 15:22:52.000000000 +0100
+++ new/yast2-core-2.22.3/configure.in 2012-02-03 17:00:54.000000000 +0100
@@ -3,7 +3,7 @@
dnl -- This file is generated by y2autoconf 2.21.7 - DO NOT EDIT! --
dnl (edit configure.in.in instead)
-AC_INIT(yast2-core, 2.22.2, http://bugs.opensuse.org/, yast2-core)
+AC_INIT(yast2-core, 2.22.3, http://bugs.opensuse.org/, yast2-core)
dnl Check for presence of file 'RPMNAME'
AC_CONFIG_SRCDIR([RPMNAME])
@@ -18,7 +18,7 @@
AM_INIT_AUTOMAKE(tar-ustar -Wno-portability)
dnl Important YaST2 variables
-VERSION="2.22.2"
+VERSION="2.22.3"
RPMNAME="yast2-core"
MAINTAINER="Martin Vidner "
--
To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-commit+help@opensuse.org