Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libproxy for openSUSE:Factory checked in at 2024-10-04 17:08:24 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libproxy (Old) and /work/SRC/openSUSE:Factory/.libproxy.new.19354 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "libproxy" Fri Oct 4 17:08:24 2024 rev:92 rq:1205372 version:0.5.9 Changes: -------- --- /work/SRC/openSUSE:Factory/libproxy/libproxy.changes 2024-06-20 16:46:37.764426314 +0200 +++ /work/SRC/openSUSE:Factory/.libproxy.new.19354/libproxy.changes 2024-10-04 17:08:30.627739514 +0200 @@ -1,0 +2,15 @@ +Wed Oct 2 14:24:50 UTC 2024 - Dominique Leuenberger <dimstar@opensuse.org> + +- Update to version 0.5.9: + + Ignore invalid proxy URL. + + Memleak fixes. + + kde: Add ReversedException support. + + Fix memory leak using PX_FORCE_CONFIG. + + Update msys2 build steps. + + Remove white space in key value. +- Changes from version 0.5.8: + + Update repology list. + + Properly handle empty proxy ignore entry. + + Add support for direct keyword in PAC. + +------------------------------------------------------------------- Old: ---- libproxy-0.5.7.obscpio New: ---- libproxy-0.5.9.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libproxy.spec ++++++ --- /var/tmp/diff_new_pack.uBdF4w/_old 2024-10-04 17:08:31.727785472 +0200 +++ /var/tmp/diff_new_pack.uBdF4w/_new 2024-10-04 17:08:31.727785472 +0200 @@ -32,7 +32,7 @@ %define _name libproxy Name: libproxy%{?dash}%{?name_suffix} -Version: 0.5.7 +Version: 0.5.9 Release: 0 Summary: Automatic proxy configuration management for applications License: GPL-2.0-or-later AND LGPL-2.1-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.uBdF4w/_old 2024-10-04 17:08:31.779787644 +0200 +++ /var/tmp/diff_new_pack.uBdF4w/_new 2024-10-04 17:08:31.783787811 +0200 @@ -3,7 +3,7 @@ <service name="obs_scm" mode="manual"> <param name="scm">git</param> <param name="url">https://github.com/libproxy/libproxy.git</param> - <param name="revision">0.5.7</param> + <param name="revision">0.5.9</param> <param name="versionformat">@PARENT_TAG@+@TAG_OFFSET@</param> <param name="versionrewrite-pattern">v?(.*)\+0</param> <param name="versionrewrite-replacement">\1</param> ++++++ libproxy-0.5.7.obscpio -> libproxy-0.5.9.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/README.md new/libproxy-0.5.9/README.md --- old/libproxy-0.5.7/README.md 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/README.md 2024-10-02 16:22:15.000000000 +0200 @@ -41,15 +41,15 @@ ## Repology [](https://repology.org/project/libproxy/versions) -[](https://repology.org/project/libproxy/versions) -[](https://repology.org/project/libproxy/versions) +[](https://repology.org/project/libproxy/versions) +[](https://repology.org/project/libproxy/versions) [](https://repology.org/project/libproxy/versions) [](https://repology.org/project/libproxy/versions) [](https://repology.org/project/libproxy/versions) [](https://repology.org/project/libproxy/versions) [](https://repology.org/project/libproxy/versions) [](https://repology.org/project/libproxy/versions) -[](https://repology.org/project/libproxy/versions) +[](https://repology.org/project/libproxy/versions) [](https://repology.org/project/libproxy/versions) -[](https://repology.org/project/libproxy/versions) +[](https://repology.org/project/libproxy/versions) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/docs/build-steps.md new/libproxy-0.5.9/docs/build-steps.md --- old/libproxy-0.5.7/docs/build-steps.md 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/docs/build-steps.md 2024-10-02 16:22:15.000000000 +0200 @@ -61,7 +61,7 @@ ### Dependencies ``` -pacman -S base-devel git mingw-w64-x86_64-toolchain mingw-w64-x86_64-ccache mingw-w64-x86_64-pkg-config mingw-w64-x86_64-gobject-introspection mingw-w64-x86_64-python-gobject mingw-w64-x86_64-meson mingw-w64-x86_64-glib mingw-w64-x86_64-duktape mingw-w64-x86_64-gi-docgen mingw-w64-x86_64-curl mingw-w64-x86_64-vala +pacman -S base-devel git mingw-w64-x86_64-toolchain mingw-w64-x86_64-ccache mingw-w64-x86_64-pkg-config mingw-w64-x86_64-gobject-introspection mingw-w64-x86_64-python-gobject mingw-w64-x86_64-meson mingw-w64-x86_64-glib2 mingw-w64-x86_64-duktape mingw-w64-x86_64-gi-docgen mingw-w64-x86_64-curl mingw-w64-x86_64-vala mingw-w64-x86_64-gsettings-desktop-schemas ``` ### Build Setup diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/meson.build new/libproxy-0.5.9/meson.build --- old/libproxy-0.5.7/meson.build 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/meson.build 2024-10-02 16:22:15.000000000 +0200 @@ -1,5 +1,5 @@ project('libproxy', 'c', - version: '0.5.7', + version: '0.5.9', meson_version: '>= 0.59.0', default_options: [ 'warning_level=2', 'werror=false', 'c_std=gnu11', ], ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/src/backend/plugins/config-kde/config-kde.c new/libproxy-0.5.9/src/backend/plugins/config-kde/config-kde.c --- old/libproxy-0.5.7/src/backend/plugins/config-kde/config-kde.c 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/src/backend/plugins/config-kde/config-kde.c 2024-10-02 16:22:15.000000000 +0200 @@ -50,6 +50,7 @@ char *socks_proxy; KdeProxyType proxy_type; char *pac_script; + gboolean reversed_exception; }; G_DEFINE_FINAL_TYPE_WITH_CODE (PxConfigKde, @@ -149,6 +150,8 @@ self->pac_script = g_strdup (value->str); } else if (strcmp (kv[0], "ProxyType") == 0) { self->proxy_type = atoi (value->str); + } else if (strcmp (kv[0], "ReversedException") == 0) { + self->reversed_exception = !!atoi (value->str); } } } while (line); @@ -245,8 +248,14 @@ if (self->proxy_type == KDE_PROXY_TYPE_NONE) return; - if (px_manager_is_ignore (uri, self->no_proxy)) - return; + if (self->reversed_exception) { + /* ReversedException flips the meaning of the ignore list */ + if (!px_manager_is_ignore (uri, self->no_proxy)) + return; + } else { + if (px_manager_is_ignore (uri, self->no_proxy)) + return; + } scheme = g_uri_get_scheme (uri); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/src/backend/plugins/config-sysconfig/config-sysconfig.c new/libproxy-0.5.9/src/backend/plugins/config-sysconfig/config-sysconfig.c --- old/libproxy-0.5.7/src/backend/plugins/config-sysconfig/config-sysconfig.c 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/src/backend/plugins/config-sysconfig/config-sysconfig.c 2024-10-02 16:22:15.000000000 +0200 @@ -114,6 +114,7 @@ value = g_string_new (kv[1]); g_string_replace (value, "\"", "", 0); g_string_replace (value, "\r", "", 0); + g_string_replace (value, " ", "", 0); if (strcmp (kv[0], "PROXY_ENABLED") == 0) { self->proxy_enabled = g_ascii_strncasecmp (value->str, "yes", 3) == 0; @@ -183,6 +184,7 @@ g_clear_object (&self->monitor); g_clear_pointer (&self->no_proxy, g_strfreev); + g_clear_pointer (&self->config_file, g_free); G_OBJECT_CLASS (px_config_sysconfig_parent_class)->dispose (object); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/src/backend/px-manager.c new/libproxy-0.5.9/src/backend/px-manager.c --- old/libproxy-0.5.7/src/backend/px-manager.c 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/src/backend/px-manager.c 2024-10-02 16:22:15.000000000 +0200 @@ -141,13 +141,13 @@ px_manager_add_config_plugin (PxManager *self, GType type) { - PxConfig *config = g_object_new (type, "config-option", self->config_option, NULL); + g_autoptr (PxConfig) config = g_object_new (type, "config-option", self->config_option, NULL); PxConfigInterface *ifc = PX_CONFIG_GET_IFACE (config); const char *env = g_getenv ("PX_FORCE_CONFIG"); const char *force_config = self->config_plugin ? self->config_plugin : env; if (!force_config || g_strcmp0 (ifc->name, force_config) == 0) - self->config_plugins = g_list_insert_sorted (self->config_plugins, config, config_order_compare); + self->config_plugins = g_list_insert_sorted (self->config_plugins, g_steal_pointer (&config), config_order_compare); } static void @@ -235,11 +235,8 @@ { PxManager *self = PX_MANAGER (object); - for (GList *list = self->config_plugins; list && list->data; list = list->next) - g_clear_object (&list->data); - - for (GList *list = self->pacrunner_plugins; list && list->data; list = list->next) - g_clear_object (&list->data); + g_clear_list (&self->config_plugins, g_object_unref); + g_clear_list (&self->pacrunner_plugins, g_object_unref); g_clear_pointer (&self->config_plugin, g_free); #ifdef HAVE_CURL @@ -525,6 +522,8 @@ if (test_uri) px_strv_builder_add_proxy (builder, proxy_string); } + } else if (g_strv_length (word_split) == 1 && g_ascii_strncasecmp (word_split[0], "direct", 6) == 0) { + px_strv_builder_add_proxy (builder, "direct://"); } } } @@ -667,6 +666,10 @@ g_debug ("%s: Config[%d] = %s", __FUNCTION__, idx, config[idx]); + /* Ignore invalid proxy URL, so we won't call GUri API on NULL. */ + if (!conf_url) + continue; + if (px_manager_expand_wpad (self, conf_url) || px_manager_expand_pac (self, conf_url)) { GList *list; @@ -716,7 +719,7 @@ if (g_strcmp0 (ignore, "*") == 0) return TRUE; - if (!host || !ignore) + if (!host || !ignore || strlen (ignore) == 0) return FALSE; ignore_split = g_strsplit (ignore, ":", -1); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/tests/data/px-manager-sample.pac new/libproxy-0.5.9/tests/data/px-manager-sample.pac --- old/libproxy-0.5.7/tests/data/px-manager-sample.pac 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/tests/data/px-manager-sample.pac 2024-10-02 16:22:15.000000000 +0200 @@ -26,12 +26,12 @@ alert("DEFAULT") + if (dnsDomainIs(host, "www.example.com")) + return "PROXY 127.0.0.1:1984; DIRECT" + /* Don't send non-FQDN or private IP auths to us */ if (isPlainHostName(host) || isInNet(resolved_ip, "192.0.2.0","255.255.255.0") || privateIP.test(resolved_ip)) return "DIRECT"; - if (dnsDomainIs(host, "www.example.com")) - return "PROXY 127.0.0.1:1984" - /* Return nothing to check wrong output */ } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libproxy-0.5.7/tests/px-manager-test.c new/libproxy-0.5.9/tests/px-manager-test.c --- old/libproxy-0.5.7/tests/px-manager-test.c 2024-06-18 09:16:59.000000000 +0200 +++ new/libproxy-0.5.9/tests/px-manager-test.c 2024-10-02 16:22:15.000000000 +0200 @@ -234,6 +234,7 @@ config = px_manager_get_proxies_sync (self->manager, "https://www.example.com"); g_assert_nonnull (config); g_assert_cmpstr (config[0], ==, "http://127.0.0.1:1984"); + g_assert_cmpstr (config[1], ==, "direct://"); config = px_manager_get_proxies_sync (self->manager, "https://192.168.10.4"); g_assert_nonnull (config); ++++++ libproxy.obsinfo ++++++ --- /var/tmp/diff_new_pack.uBdF4w/_old 2024-10-04 17:08:32.187804689 +0200 +++ /var/tmp/diff_new_pack.uBdF4w/_new 2024-10-04 17:08:32.191804857 +0200 @@ -1,5 +1,5 @@ name: libproxy -version: 0.5.7 -mtime: 1718695019 -commit: 2686d35cfa5db970d4ba65e2951ebc8183b1be82 +version: 0.5.9 +mtime: 1727878935 +commit: 77e2a2b88a319974cf099c8eaaaa03030bc4c0d4