commit chromium for openSUSE:Factory

9 Aug 2019

Hello community,

here is the log from the commit of package chromium for openSUSE:Factory checked in at 2019-08-09 16:52:34
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/chromium (Old)
 and      /work/SRC/openSUSE:Factory/.chromium.new.9556 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "chromium"

Fri Aug  9 16:52:34 2019 rev:225 rq:721717 version:76.0.3809.87

Changes:
--------
--- /work/SRC/openSUSE:Factory/chromium/chromium.changes	2019-08-05 10:40:49.255302733 +0200
+++ /work/SRC/openSUSE:Factory/.chromium.new.9556/chromium.changes	2019-08-09 16:52:43.477478182 +0200
@@ -1,0 +2,11 @@
+Thu Aug  8 07:27:14 UTC 2019 - Tomáš Chvátal <tchvatal@suse.com>
+
+- Add patches to fix few compilation issues:
+  * chromium-angle-inline.patch
+  * chromium-fix-char_traits.patch bsc#1144625
+- Remove not properly applying old-glibc patch:
+  * chromium-old-glibc.patch
+- Disable various gcc warnings as upstream does not care and it
+  just bloats the buildlog (from debian)
+
+-------------------------------------------------------------------
@@ -4 +15 @@
-- Update to 76.0.3809.87:
+- Update to 76.0.3809.87 bsc#1143492:

Old:
----
  BUILD.gn
  chromium-old-glibc.patch

New:
----
  chromium-angle-inline.patch
  chromium-fix-char_traits.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ chromium.spec ++++++
--- /var/tmp/diff_new_pack.XFLpug/_old	2019-08-09 16:52:56.701475012 +0200
+++ /var/tmp/diff_new_pack.XFLpug/_new	2019-08-09 16:52:56.725475007 +0200
@@ -64,8 +64,6 @@
 Group:          Productivity/Networking/Web/Browsers
 URL:            https://www.chromium.org/
 Source0:        https://commondatastorage.googleapis.com/chromium-browser-official/%{rname}-%{version}.tar.xz
-# Toolchain definitions
-Source1:        BUILD.gn
 Source30:       master_preferences
 Source100:      chromium-browser.sh
 Source101:      chromium-browser.desktop
@@ -87,10 +85,11 @@
 Patch7:         chromium-sandbox-pie.patch
 Patch8:         chromium-system-icu.patch
 Patch9:         chromium-system-libusb.patch
-Patch10:        chromium-old-glibc.patch
 Patch11:        chromium-skia-aarch64-buildfix.patch
 Patch12:        gcc-lto-rsp-clobber.patch
 Patch13:        gcc-enable-lto.patch
+Patch14:        chromium-angle-inline.patch
+Patch16:        chromium-fix-char_traits.patch
 # gcc patches
 Patch20:        chromium-76-gcc-ambiguous-nodestructor.patch
 Patch21:        chromium-76-gcc-blink-constexpr.patch
@@ -293,10 +292,6 @@
 %setup -q -n %{rname}-%{version}
 %autopatch -p1
 
-# Copy the toolchain settings
-mkdir toolchain
-cp %{SOURCE1} toolchain/BUILD.gn
-
 # Fix the path to nodejs binary
 mkdir -p third_party/node/linux/node-linux-x64/bin
 ln -s %{_bindir}/node third_party/node/linux/node-linux-x64/bin/node
@@ -534,12 +529,23 @@
 export CXX=clang++
 %else
 # REDUCE DEBUG as it gets TOO large
-# -Wno-return-type :: upstream does not care about this
 ARCH_FLAGS="`echo %{optflags} | sed -e 's/^-g / /g' -e 's/ -g / /g' -e 's/ -g$//g'`"
-export CFLAGS="${ARCH_FLAGS} -fpermissive -Wno-return-type"
-export CXXFLAGS="${ARCH_FLAGS} -fpermissive -Wno-return-type"
+export CXXFLAGS="${ARCH_FLAGS}"
+# extra flags to reduce warnings that aren't very useful
+export CXXFLAGS="${CXXFLAGS} -Wno-pedantic -Wno-unused-result -Wno-unused-function -Wno-unused-variable -Wno-unused-but-set-variable -Wno-deprecated-declarations"
+# ignore warnings for minor mistakes that are too common
+export CXXFLAGS="${CXXFLAGS} -Wno-return-type -Wno-parentheses -Wno-misleading-indentation"
+# ignore warnings that are not supported well until gcc 8
+export CXXFLAGS="${CXXFLAGS} -Wno-attributes -Wno-subobject-linkage"
+# ignore warnings due to gcc bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84055)
+export CXXFLAGS="${CXXFLAGS} -Wno-ignored-attributes"
+# ingore new gcc 8 warnings that aren't yet handled upstream
+export CXXFLAGS="${CXXFLAGS} -Wno-address -Wno-dangling-else -Wno-class-memaccess -Wno-invalid-offsetof -Wno-packed-not-aligned"
+export CFLAGS="${CXXFLAGS}"
 export CC=gcc
 export CXX=g++
+export AR=ar
+export NM=nm
 %if 0%{?suse_version} <= 1500
 export CC=gcc-8
 export CXX=g++-8
@@ -594,7 +600,8 @@
 # Create the configuration for GN
 # Available options: out/Release/gn args --list out/Release/
 myconf_gn=""
-myconf_gn+=" custom_toolchain=\"./toolchain:default\""
+myconf_gn+=" custom_toolchain=\"//build/toolchain/linux/unbundle:default\""
+myconf_gn+=" host_toolchain=\"//build/toolchain/linux/unbundle:default\""
 myconf_gn+=" linux_use_bundled_binutils=false"
 myconf_gn+=" use_custom_libcxx=false"
 myconf_gn+=" is_debug=false"

++++++ chromium-angle-inline.patch ++++++
...
From 4c0a23611b3906855db7b93da2f34aec57930cdf Mon Sep 17 00:00:00 2001
From: Geoff Lang <geofflang@chromium.org>
Date: Tue, 25 Jun 2019 10:56:29 -0400
Subject: [PATCH] Update ValidateSamplerParameterBase to use const parameters.
ValidateSamplerParameterBase is called with both const and non-const
parameter pointers which caused our explicit template instantiations to
not cover all cases resulting in link errors.  Force the parameters to
always be const so that our instantiations cover everything.

BUG=angleproject:3555

Change-Id: Ibf92572ba80a689c75dcdc70e5153d9941da76f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1676305
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
---

diff --git a/third_party/angle/src/libANGLE/validationES.cpp b/third_party/angle/src/libANGLE/validationES.cpp
index 041803a..3f402f6 100644
--- a/third_party/angle/src/libANGLE/validationES.cpp
+++ b/third_party/angle/src/libANGLE/validationES.cpp
@@ -189,7 +189,9 @@
 }
 
 template <typename ParamType>
-bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool restrictedWrapModes)
+bool ValidateTextureWrapModeValue(Context *context,
+                                  const ParamType *params,
+                                  bool restrictedWrapModes)
 {
     switch (ConvertToGLenum(params[0]))
     {
@@ -223,7 +225,9 @@
 }
 
 template <typename ParamType>
-bool ValidateTextureMinFilterValue(Context *context, ParamType *params, bool restrictedMinFilter)
+bool ValidateTextureMinFilterValue(Context *context,
+                                   const ParamType *params,
+                                   bool restrictedMinFilter)
 {
     switch (ConvertToGLenum(params[0]))
     {
@@ -252,7 +256,7 @@
 }
 
 template <typename ParamType>
-bool ValidateTextureMagFilterValue(Context *context, ParamType *params)
+bool ValidateTextureMagFilterValue(Context *context, const ParamType *params)
 {
     switch (ConvertToGLenum(params[0]))
     {
@@ -269,7 +273,7 @@
 }
 
 template <typename ParamType>
-bool ValidateTextureCompareModeValue(Context *context, ParamType *params)
+bool ValidateTextureCompareModeValue(Context *context, const ParamType *params)
 {
     // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
     switch (ConvertToGLenum(params[0]))
@@ -287,7 +291,7 @@
 }
 
 template <typename ParamType>
-bool ValidateTextureCompareFuncValue(Context *context, ParamType *params)
+bool ValidateTextureCompareFuncValue(Context *context, const ParamType *params)
 {
     // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
     switch (ConvertToGLenum(params[0]))
@@ -311,7 +315,7 @@
 }
 
 template <typename ParamType>
-bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params)
+bool ValidateTextureSRGBDecodeValue(Context *context, const ParamType *params)
 {
     if (!context->getExtensions().textureSRGBDecode)
     {
@@ -5996,7 +6000,7 @@
                                   GLenum pname,
                                   GLsizei bufSize,
                                   bool vectorParams,
-                                  ParamType *params)
+                                  const ParamType *params)
 {
     if (context->getClientMajorVersion() < 3)
     {
@@ -6099,8 +6103,13 @@
     return true;
 }
 
-template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, GLfloat *);
-template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, GLint *);
+template bool ValidateSamplerParameterBase(Context *,
+                                           GLuint,
+                                           GLenum,
+                                           GLsizei,
+                                           bool,
+                                           const GLfloat *);
+template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, const GLint *);
 template bool ValidateSamplerParameterBase(Context *,
                                            GLuint,
                                            GLenum,
diff --git a/third_party/angle/src/libANGLE/validationES.h b/third_party/angle/src/libANGLE/validationES.h
index c61bda6..4b06d28 100644
--- a/third_party/angle/src/libANGLE/validationES.h
+++ b/third_party/angle/src/libANGLE/validationES.h
@@ -584,7 +584,7 @@
                                   GLenum pname,
                                   GLsizei bufSize,
                                   bool vectorParams,
-                                  ParamType *params);
+                                  const ParamType *params);
 
 bool ValidateGetInternalFormativBase(Context *context,
                                      GLenum target,
++++++ chromium-fix-char_traits.patch ++++++
--- a/base/strings/char_traits.h
+++ b/base/strings/char_traits.h
@@ -67,9 +67,9 @@
   return __builtin_memcmp(s1, s2, n);
 #else
   for (; n; --n, ++s1, ++s2) {
-    if (*s1 < *s2)
+    if ((unsigned char)*s1 < (unsigned char)*s2)
       return -1;
-    if (*s1 > *s2)
+    if ((unsigned char)*s1 > (unsigned char)*s2)
       return 1;
   }
   return 0;

    

root

tags

participants (1)