Hello community, here is the log from the commit of package evolution-ews for openSUSE:Factory checked in at 2019-11-29 15:56:54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/evolution-ews (Old) and /work/SRC/openSUSE:Factory/.evolution-ews.new.26869 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "evolution-ews" Fri Nov 29 15:56:54 2019 rev:98 rq:750936 version:3.34.2 Changes: -------- --- /work/SRC/openSUSE:Factory/evolution-ews/evolution-ews.changes 2019-10-17 12:58:01.785496687 +0200 +++ /work/SRC/openSUSE:Factory/.evolution-ews.new.26869/evolution-ews.changes 2019-11-29 15:58:16.308925048 +0100 @@ -1,0 +2,10 @@ +Fri Nov 22 11:11:34 UTC 2019 - Bjørn Lie <bjorn.lie@gmail.com> + +- Update to version 3.34.2: + + Some meetings shown as plain events. + + Disconnect signal handlers on connection object in dispose of + book/calendar backend. + + Bugs fixed: glgo#GNOME/evolution-ews#64, + glgo#GNOME/evolution-ews#70. + +------------------------------------------------------------------- Old: ---- evolution-ews-3.34.1.tar.xz New: ---- evolution-ews-3.34.2.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ evolution-ews.spec ++++++ --- /var/tmp/diff_new_pack.3XsR2R/_old 2019-11-29 15:58:18.028924061 +0100 +++ /var/tmp/diff_new_pack.3XsR2R/_new 2019-11-29 15:58:18.028924061 +0100 @@ -1,7 +1,7 @@ # # spec file for package evolution-ews # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -20,7 +20,7 @@ %define _version %(echo %{version} | grep -E -o '[0-9]+\.[0-9]+\.[0-9]+') Name: evolution-ews -Version: 3.34.1 +Version: 3.34.2 Release: 0 Summary: Exchange Connector for Evolution, compatible with Exchange 2007 and later License: LGPL-2.1-only ++++++ evolution-ews-3.34.1.tar.xz -> evolution-ews-3.34.2.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/CMakeLists.txt new/evolution-ews-3.34.2/CMakeLists.txt --- old/evolution-ews-3.34.1/CMakeLists.txt 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/CMakeLists.txt 2019-11-22 11:03:30.000000000 +0100 @@ -4,7 +4,7 @@ cmake_policy(VERSION 3.1) project(evolution-ews - VERSION 3.34.1 + VERSION 3.34.2 LANGUAGES C) set(PROJECT_BUGREPORT "https://gitlab.gnome.org/GNOME/evolution-ews/issues/") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/NEWS new/evolution-ews-3.34.2/NEWS --- old/evolution-ews-3.34.1/NEWS 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/NEWS 2019-11-22 11:03:30.000000000 +0100 @@ -1,3 +1,14 @@ +Evolution-EWS 3.34.2 2019-11-22 +------------------------------- + +Bug Fixes: + I#64 - "Listen for server notifications" does not work with OAuth2 (Milan Crha) + I#70 - Fails to delete one instance of a recurring event (Milan Crha) + +Miscellaneous: + Some meetings shown as plain events (Milan Crha) + Disconnect signal handlers on connection object in dispose of book/calendar backend (Milan Crha) + Evolution-EWS 3.34.1 2019-10-07 ------------------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/src/addressbook/e-book-backend-ews.c new/evolution-ews-3.34.2/src/addressbook/e-book-backend-ews.c --- old/evolution-ews-3.34.1/src/addressbook/e-book-backend-ews.c 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/src/addressbook/e-book-backend-ews.c 2019-11-22 11:03:30.000000000 +0100 @@ -4035,11 +4035,7 @@ { EBookBackendEws *bbews = E_BOOK_BACKEND_EWS (object); - g_rec_mutex_lock (&bbews->priv->cnc_lock); - - g_clear_object (&bbews->priv->cnc); - - g_rec_mutex_unlock (&bbews->priv->cnc_lock); + ebb_ews_unset_connection (bbews); /* Chain up to parent's method. */ G_OBJECT_CLASS (e_book_backend_ews_parent_class)->dispose (object); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/src/calendar/e-cal-backend-ews-utils.c new/evolution-ews-3.34.2/src/calendar/e-cal-backend-ews-utils.c --- old/evolution-ews-3.34.1/src/calendar/e-cal-backend-ews-utils.c 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/src/calendar/e-cal-backend-ews-utils.c 2019-11-22 11:03:30.000000000 +0100 @@ -2089,7 +2089,7 @@ return index; rrule = i_cal_property_get_rrule (prop); - if (rrule) { + if (!rrule) { g_object_unref (prop); return index; } @@ -2110,7 +2110,6 @@ i_cal_time_set_timezone (o_time, timezone); ritr = i_cal_recur_iterator_new (rrule, dtstart); - next = i_cal_recur_iterator_next (ritr); for (next = i_cal_recur_iterator_next (ritr); next && !i_cal_time_is_null_time (next); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/src/calendar/e-cal-backend-ews.c new/evolution-ews-3.34.2/src/calendar/e-cal-backend-ews.c --- old/evolution-ews-3.34.1/src/calendar/e-cal-backend-ews.c 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/src/calendar/e-cal-backend-ews.c 2019-11-22 11:03:30.000000000 +0100 @@ -794,7 +794,8 @@ item_id = e_ews_item_get_id (item); - if (e_ews_item_get_is_meeting (item)) { + if (e_ews_item_get_is_meeting (item) || + e_ews_item_get_attendees (item)) { const GSList *link; gboolean is_response_requested = e_ews_item_get_is_response_requested (item); gchar *user_email; @@ -4217,11 +4218,7 @@ { ECalBackendEws *cbews = E_CAL_BACKEND_EWS (object); - g_rec_mutex_lock (&cbews->priv->cnc_lock); - - g_clear_object (&cbews->priv->cnc); - - g_rec_mutex_unlock (&cbews->priv->cnc_lock); + ecb_ews_unset_connection (cbews); /* Chain up to parent's method. */ G_OBJECT_CLASS (e_cal_backend_ews_parent_class)->dispose (object); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/src/server/e-ews-connection-utils.c new/evolution-ews-3.34.2/src/server/e-ews-connection-utils.c --- old/evolution-ews-3.34.1/src/server/e-ews-connection-utils.c 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/src/server/e-ews-connection-utils.c 2019-11-22 11:03:30.000000000 +0100 @@ -301,6 +301,7 @@ static gboolean ews_connection_utils_setup_bearer_auth (EEwsConnection *cnc, + SoupSession *session, SoupMessage *message, gboolean is_in_authenticate_handler, ESoupAuthBearer *bearer, @@ -324,9 +325,10 @@ e_soup_auth_bearer_set_access_token (bearer, access_token, expires_in_seconds); if (!is_in_authenticate_handler) { - SoupSession *session; - - session = e_ews_connection_ref_soup_session (cnc); + if (session) + g_object_ref (session); + else + session = e_ews_connection_ref_soup_session (cnc); ews_connection_utils_ensure_bearer_auth_usage (session, message, bearer); @@ -341,6 +343,7 @@ static gboolean ews_connection_utils_maybe_prepare_bearer_auth (EEwsConnection *cnc, + SoupSession *session, SoupMessage *message, GCancellable *cancellable) { @@ -387,7 +390,7 @@ using_bearer_auth = e_ews_connection_ref_bearer_auth (cnc); if (using_bearer_auth) { - success = ews_connection_utils_setup_bearer_auth (cnc, message, FALSE, using_bearer_auth, cancellable, &local_error); + success = ews_connection_utils_setup_bearer_auth (cnc, session, message, FALSE, using_bearer_auth, cancellable, &local_error); g_clear_object (&using_bearer_auth); } else { SoupAuth *soup_auth; @@ -409,7 +412,7 @@ soup_auth = g_object_new (E_TYPE_SOUP_AUTH_BEARER, SOUP_AUTH_HOST, soup_uri->host, NULL); - success = ews_connection_utils_setup_bearer_auth (cnc, message, FALSE, E_SOUP_AUTH_BEARER (soup_auth), cancellable, &local_error); + success = ews_connection_utils_setup_bearer_auth (cnc, session, message, FALSE, E_SOUP_AUTH_BEARER (soup_auth), cancellable, &local_error); if (success) e_ews_connection_set_bearer_auth (cnc, E_SOUP_AUTH_BEARER (soup_auth)); @@ -465,7 +468,7 @@ if (using_bearer_auth) { GError *local_error = NULL; - ews_connection_utils_setup_bearer_auth (cnc, msg, TRUE, E_SOUP_AUTH_BEARER (auth), NULL, &local_error); + ews_connection_utils_setup_bearer_auth (cnc, session, msg, TRUE, E_SOUP_AUTH_BEARER (auth), NULL, &local_error); if (local_error) soup_message_set_status_full (msg, SOUP_STATUS_IO_ERROR, local_error->message); @@ -518,6 +521,7 @@ /* Returns whether succeeded */ gboolean e_ews_connection_utils_prepare_message (EEwsConnection *cnc, + SoupSession *session, SoupMessage *message, GCancellable *cancellable) { @@ -529,14 +533,14 @@ if (source) e_soup_ssl_trust_connect (message, source); - if (!ews_connection_utils_maybe_prepare_bearer_auth (cnc, message, cancellable)) + if (!ews_connection_utils_maybe_prepare_bearer_auth (cnc, session, message, cancellable)) return FALSE; using_bearer_auth = e_ews_connection_ref_bearer_auth (cnc); if (using_bearer_auth && e_soup_auth_bearer_is_expired (using_bearer_auth) && - !ews_connection_utils_setup_bearer_auth (cnc, message, FALSE, using_bearer_auth, cancellable, &local_error)) { + !ews_connection_utils_setup_bearer_auth (cnc, session, message, FALSE, using_bearer_auth, cancellable, &local_error)) { if (local_error) { soup_message_set_status_full (message, SOUP_STATUS_BAD_REQUEST, local_error->message); g_clear_error (&local_error); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/src/server/e-ews-connection-utils.h new/evolution-ews-3.34.2/src/server/e-ews-connection-utils.h --- old/evolution-ews-3.34.1/src/server/e-ews-connection-utils.h 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/src/server/e-ews-connection-utils.h 2019-11-22 11:03:30.000000000 +0100 @@ -53,6 +53,7 @@ SoupAuth *auth, gboolean retrying); gboolean e_ews_connection_utils_prepare_message (EEwsConnection *cnc, + SoupSession *session, SoupMessage *message, GCancellable *cancellable); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/src/server/e-ews-connection.c new/evolution-ews-3.34.2/src/server/e-ews-connection.c --- old/evolution-ews-3.34.1/src/server/e-ews-connection.c 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/src/server/e-ews-connection.c 2019-11-22 11:03:30.000000000 +0100 @@ -539,7 +539,7 @@ switch (sd->op) { case EWS_SCHEDULE_OP_QUEUE_MESSAGE: - if (!e_ews_connection_utils_prepare_message (sd->cnc, sd->message, NULL)) { + if (!e_ews_connection_utils_prepare_message (sd->cnc, NULL, sd->message, NULL)) { e_ews_debug_dump_raw_soup_request (sd->message); if (sd->queue_callback) { @@ -699,7 +699,7 @@ if (cnc->priv->soup_session) { SoupMessage *msg = SOUP_MESSAGE (node->msg); - if (!e_ews_connection_utils_prepare_message (cnc, msg, node->cancellable)) { + if (!e_ews_connection_utils_prepare_message (cnc, NULL, msg, node->cancellable)) { e_ews_debug_dump_raw_soup_request (msg); QUEUE_UNLOCK (cnc); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/evolution-ews-3.34.1/src/server/e-ews-notification.c new/evolution-ews-3.34.2/src/server/e-ews-notification.c --- old/evolution-ews-3.34.1/src/server/e-ews-notification.c 2019-10-07 09:44:38.000000000 +0200 +++ new/evolution-ews-3.34.2/src/server/e-ews-notification.c 2019-11-22 11:03:30.000000000 +0100 @@ -332,6 +332,11 @@ e_ews_debug_dump_raw_soup_request (SOUP_MESSAGE (msg)); } + if (!e_ews_connection_utils_prepare_message (notification->priv->connection, notification->priv->soup_session, SOUP_MESSAGE (msg), cancellable)) { + g_object_unref (msg); + return FALSE; + } + soup_session_send_message (notification->priv->soup_session, SOUP_MESSAGE (msg)); if (!SOUP_STATUS_IS_SUCCESSFUL (SOUP_MESSAGE (msg)->status_code)) { g_object_unref (msg); @@ -436,6 +441,11 @@ soup_message_body_set_accumulate (SOUP_MESSAGE (msg)->response_body, TRUE); + if (!e_ews_connection_utils_prepare_message (notification->priv->connection, notification->priv->soup_session, SOUP_MESSAGE (msg), notification->priv->cancellable)) { + g_object_unref (msg); + return FALSE; + } + soup_session_send_message (notification->priv->soup_session, SOUP_MESSAGE (msg)); if (!SOUP_STATUS_IS_SUCCESSFUL (SOUP_MESSAGE (msg)->status_code)) { g_object_unref (msg); @@ -767,6 +777,11 @@ SOUP_MESSAGE (msg), "got-chunk", G_CALLBACK (ews_notification_soup_got_chunk), notification); + if (!e_ews_connection_utils_prepare_message (notification->priv->connection, notification->priv->soup_session, SOUP_MESSAGE (msg), notification->priv->cancellable)) { + g_object_unref (msg); + return FALSE; + } + status_code = soup_session_send_message (notification->priv->soup_session, SOUP_MESSAGE (msg)); ret = SOUP_STATUS_IS_SUCCESSFUL (status_code);