![](https://seccdn.libravatar.org/avatar/af22e20b6884acbc89be6d7736c43e92.jpg?s=120&d=mm&r=g)
Hello community, here is the log from the commit of package icecast checked in at Thu Oct 12 15:18:45 CEST 2006. -------- --- icecast/icecast.changes 2006-01-25 21:36:33.000000000 +0100 +++ /mounts/work_src_done/STABLE/icecast/icecast.changes 2006-10-11 17:23:51.000000000 +0200 @@ -1,0 +2,11 @@ +Wed Oct 11 03:22:10 CEST 2006 - tiwai@suse.de + +- added icecast-2.3.1_runas_icecast_user.patch: + run icecast as "icecast" user and group by default +- added init script +- added log/home dir to the fileist +- dont run suse_update_config/autoreconf seems unneeded. + (tested with the buildservice on 10.0->Factory) +- replaced manual configure call with %configure + +------------------------------------------------------------------- New: ---- icecast-2.3.1_runas_icecast_user.patch icecast.init ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ icecast.spec ++++++ --- /var/tmp/diff_new_pack.K5yCzO/_old 2006-10-12 15:18:24.000000000 +0200 +++ /var/tmp/diff_new_pack.K5yCzO/_new 2006-10-12 15:18:24.000000000 +0200 @@ -1,30 +1,33 @@ # # spec file for package icecast (Version 2.3.1) # -# Copyright (c) 2005 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2006 SUSE LINUX Products GmbH, Nuernberg, Germany. # This file and all modifications and additions to the pristine # package are under the same license as the package itself. # -# Please submit bugfixes or comments via http://bugs.opensuse.org +# Please submit bugfixes or comments via http://bugs.opensuse.org/ # # norootforbuild Name: icecast BuildRequires: curl-devel libtheora-devel libvorbis-devel libxslt-devel speex-devel +Prereq: /usr/sbin/useradd /usr/sbin/groupadd %insserv_prereq %fillup_prereq Summary: Audio Streaming Server Version: 2.3.1 -Release: 2 +Release: 21 Group: Productivity/Networking/Web/Servers Autoreqprov: on License: GPL Url: http://www.icecast.org/ Source: %{name}-%{version}.tar.bz2 +Source1: icecast.init +Patch: icecast-2.3.1_runas_icecast_user.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build %description -Icecast is a MP3/OGG Streaming Server able to serve many clients with -MP3/OGG audio. +Icecast is a MP3 and OGG streaming server able to serve many clients +with MP3 and OGG audio. @@ -36,36 +39,64 @@ %prep %setup -%{?suse_update_config:%{suse_update_config -f}} +%patch %build -autoreconf --force --install -CFLAGS="$RPM_OPT_FLAGS" \ -./configure --prefix=%{_prefix} \ - --libdir=%{_libdir} \ - --mandir=%{_mandir} \ - --sysconfdir=/etc \ - --localstatedir=/var +%configure make %install -make install DESTDIR=$RPM_BUILD_ROOT +%makeinstall rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/%{name} +# init script +%{__install} -d -m 0755 %{buildroot}%{_sbindir} +%{__install} -D -m 0755 %{S:1} %{buildroot}%{_sysconfdir}/init.d/%{name} +%{__ln_s} -f %{_sysconfdir}/init.d/%{name} %{buildroot}%{_sbindir}/rc%{name} +# create missing dirs +%{__install} -d -m 0755 %{buildroot}%{_var}/{lib,log}/%{name} %clean [ "$RPM_BUILD_ROOT" != "/" -a -d $RPM_BUILD_ROOT ] && rm -rf $RPM_BUILD_ROOT +%pre +/usr/sbin/groupadd -r %{name} &>/dev/null || : +/usr/sbin/useradd -o -g %{name} -s /bin/false -r -c "Icecast streaming server" -d %{_var}/lib/%{name} %{name} &>/dev/null || : + +%post +%fillup_and_insserv %{name} + +%preun +%stop_on_removal %{name} + +%postun +%restart_on_update %{name} +%insserv_cleanup + %files %defattr(-,root,root) %doc README AUTHORS COPYING NEWS TODO ChangeLog %doc doc/*.html %doc doc/*.jpg %doc doc/*.css -%config(noreplace) /etc/%{name}.xml +%doc conf/*.dist +%config(noreplace) %attr(640,root,%{name}) /etc/%{name}.xml %{_bindir}/icecast %{_datadir}/icecast +%{_sbindir}/rc%{name} +%{_sysconfdir}/init.d/%{name} +# TODO: enable chroot support in this dir +%{_var}/lib/%{name} +%attr(755,%{name},%{name}) %{_var}/log/%{name} %changelog -n icecast +* Wed Oct 11 2006 - tiwai@suse.de +- added icecast-2.3.1_runas_icecast_user.patch: + run icecast as "icecast" user and group by default +- added init script +- added log/home dir to the fileist +- dont run suse_update_config/autoreconf seems unneeded. + (tested with the buildservice on 10.0->Factory) +- replaced manual configure call with %%configure * Wed Jan 25 2006 - mls@suse.de - converted neededforbuild to BuildRequires * Mon Dec 12 2005 - tiwai@suse.de ++++++ icecast-2.3.1_runas_icecast_user.patch ++++++ Index: conf/icecast_minimal.xml.in =================================================================== --- conf/icecast_minimal.xml.in.orig +++ conf/icecast_minimal.xml.in @@ -32,4 +32,19 @@ <errorlog>error.log</errorlog> <loglevel>3</loglevel> <!-- 4 Debug, 3 Info, 2 Warn, 1 Error --> </logging> + <security> + <chroot>0</chroot> + <!-- + Note from the packager: + For security reasons you should not run the icecast server as root. + SUSE adds a icecast user and group for this purpose. + + If you change the user/group here you need to change the ownership + of the @localstatedir@/log/@PACKAGE@ aswell + --> + <changeowner> + <user>icecast</user> + <group>icecast</group> + </changeowner> + </security> </icecast> Index: conf/icecast_shoutcast_compat.xml.in =================================================================== --- conf/icecast_shoutcast_compat.xml.in.orig +++ conf/icecast_shoutcast_compat.xml.in @@ -56,5 +56,17 @@ </logging> <security> <chroot>0</chroot> + <!-- + Note from the packager: + For security reasons you should not run the icecast server as root. + SUSE adds a icecast user and group for this purpose. + + If you change the user/group here you need to change the ownership + of the @localstatedir@/log/@PACKAGE@ aswell + --> + <changeowner> + <user>icecast</user> + <group>icecast</group> + </changeowner> </security> </icecast> Index: conf/icecast_urlauth.xml.in =================================================================== --- conf/icecast_urlauth.xml.in.orig +++ conf/icecast_urlauth.xml.in @@ -45,5 +45,17 @@ </logging> <security> <chroot>0</chroot> + <!-- + Note from the packager: + For security reasons you should not run the icecast server as root. + SUSE adds a icecast user and group for this purpose. + + If you change the user/group here you need to change the ownership + of the @localstatedir@/log/@PACKAGE@ aswell + --> + <changeowner> + <user>icecast</user> + <group>icecast</group> + </changeowner> </security> </icecast> Index: conf/icecast.xml.in =================================================================== --- conf/icecast.xml.in.orig +++ conf/icecast.xml.in @@ -172,10 +172,16 @@ <security> <chroot>0</chroot> <!-- + Note from the packager: + For security reasons you should not run the icecast server as root. + SUSE adds a icecast user and group for this purpose. + + If you change the user/group here you need to change the ownership + of the @localstatedir@/log/@PACKAGE@ aswell + --> <changeowner> - <user>nobody</user> - <group>nogroup</group> + <user>icecast</user> + <group>icecast</group> </changeowner> - --> </security> </icecast> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org
participants (1)
-
root@suse.de