Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package lollypop for openSUSE:Factory checked in at 2024-06-24 20:53:05 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lollypop (Old) and /work/SRC/openSUSE:Factory/.lollypop.new.18349 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "lollypop" Mon Jun 24 20:53:05 2024 rev:168 rq:1182633 version:1.4.40 Changes: -------- --- /work/SRC/openSUSE:Factory/lollypop/lollypop.changes 2024-04-15 20:23:55.948713104 +0200 +++ /work/SRC/openSUSE:Factory/.lollypop.new.18349/lollypop.changes 2024-06-24 20:54:15.718435837 +0200 @@ -1,0 +2,5 @@ +Sat Jun 22 14:06:58 UTC 2024 - antoine.belvire@opensuse.org + +- Update to version 1.4.40: Fix an issue on mobile devices. + +------------------------------------------------------------------- Old: ---- lollypop-1.4.39.obscpio New: ---- lollypop-1.4.40.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lollypop.spec ++++++ --- /var/tmp/diff_new_pack.0mTHnN/_old 2024-06-24 20:54:16.258455595 +0200 +++ /var/tmp/diff_new_pack.0mTHnN/_new 2024-06-24 20:54:16.258455595 +0200 @@ -17,7 +17,7 @@ Name: lollypop -Version: 1.4.39 +Version: 1.4.40 Release: 0 Summary: GNOME music playing application License: GPL-3.0-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.0mTHnN/_old 2024-06-24 20:54:16.294456912 +0200 +++ /var/tmp/diff_new_pack.0mTHnN/_new 2024-06-24 20:54:16.298457058 +0200 @@ -1,7 +1,7 @@ <services> <service mode="disabled" name="obs_scm"> <param name="changesgenerate">enable</param> - <param name="revision">1.4.39</param> + <param name="revision">1.4.40</param> <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> <param name="versionformat">@PARENT_TAG@</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.0mTHnN/_old 2024-06-24 20:54:16.318457790 +0200 +++ /var/tmp/diff_new_pack.0mTHnN/_new 2024-06-24 20:54:16.318457790 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> - <param name="changesrevision">bc2195de11bd67bd69e924e64cb290fd994cb11b</param></service></servicedata> + <param name="changesrevision">5250d38610db084c81934468d94a639b3c263de3</param></service></servicedata> (No newline at EOF) ++++++ lollypop-1.4.39.obscpio -> lollypop-1.4.40.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.39/data/SettingsDialog.ui new/lollypop-1.4.40/data/SettingsDialog.ui --- old/lollypop-1.4.39/data/SettingsDialog.ui 2024-04-14 10:52:33.000000000 +0200 +++ new/lollypop-1.4.40/data/SettingsDialog.ui 2024-06-13 13:53:56.000000000 +0200 @@ -591,7 +591,7 @@ <object class="HdyActionRow"> <property name="visible">True</property> <property name="can-focus">True</property> - <property name="title" translatable="yes">Use a recent version of youtube-dl</property> + <property name="title" translatable="yes">Use a recent version of yt-dlp</property> <property name="activatable-widget">recent-youtube-dl_boolean</property> <child> <object class="GtkSwitch" id="recent-youtube-dl_boolean"> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.39/data/org.gnome.Lollypop.appdata.xml.in new/lollypop-1.4.40/data/org.gnome.Lollypop.appdata.xml.in --- old/lollypop-1.4.39/data/org.gnome.Lollypop.appdata.xml.in 2024-04-14 10:52:33.000000000 +0200 +++ new/lollypop-1.4.40/data/org.gnome.Lollypop.appdata.xml.in 2024-06-13 13:53:56.000000000 +0200 @@ -12,17 +12,24 @@ <p>Lollypop is a lightweight modern music player designed to work excellently on the GNOME desktop environment. It also features a party mode which will auto-select party-related playlists; allows access the player from your couch thanks to it fullscreen mode; fetches lyrics, artwork and biography online; and provides native support for ReplayGain.</p> </description> <releases> - <release version="1.4.39" date="2024-04-14"> + <release version="1.4.40" date="2024-06-13"> <description> - Fix startup notifications - Fix playlist export - Fix suspend inhibitor + Fix scrolling issue on mobile devices </description> </release> </releases> <screenshots> <screenshot type="default"> <image type="source" width="1754" height="1095">https://gitlab.gnome.org/gnumdk/lollypop-help/raw/master/screenshots/lollypop.jpg</image> + <caption>Main window</caption> + </screenshot> + <screenshot> + <image type="source" width="1920" height="1080">https://gitlab.gnome.org/gnumdk/lollypop-help/raw/master/screenshots/lollypop2.jpg</image> + <caption>Mini player</caption> + </screenshot> + <screenshot> + <image type="source" width="597" height="853">https://gitlab.gnome.org/gnumdk/lollypop-help/raw/master/screenshots/lollypop3.jpg</image> + <caption>Fullscreen player</caption> </screenshot> </screenshots> <translation type="gettext">lollypop</translation> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.39/lollypop/mpris.py new/lollypop-1.4.40/lollypop/mpris.py --- old/lollypop-1.4.39/lollypop/mpris.py 2024-04-14 10:52:33.000000000 +0200 +++ new/lollypop-1.4.40/lollypop/mpris.py 2024-06-13 13:53:56.000000000 +0200 @@ -36,9 +36,11 @@ method_inargs[method.name] = tuple( arg.signature for arg in method.in_args) - con.register_object(object_path=path, - interface_info=interface, - method_call_closure=self.on_method_call) + con.register_object(path, + interface, + self.on_method_call, + None, + None) self.method_inargs = method_inargs self.method_outargs = method_outargs diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.39/lollypop/view.py new/lollypop-1.4.40/lollypop/view.py --- old/lollypop-1.4.39/lollypop/view.py 2024-04-14 10:52:33.000000000 +0200 +++ new/lollypop-1.4.40/lollypop/view.py 2024-06-13 13:53:56.000000000 +0200 @@ -20,6 +20,13 @@ from lollypop.helper_filtering import FilteringHelper +class Reveal: + NONE = 0 + TRUE = 1 + FALSE = 2 + +REVEAL_DELTA=300 + class View(Gtk.Grid, AdaptiveHelper, FilteringHelper, SignalsHelper): """ Generic view @@ -240,12 +247,14 @@ """ if self.__banner is not None: reveal = self.__should_reveal_header(adj) - self.__banner.set_reveal_child(reveal) - if reveal: + if reveal == Reveal.TRUE: + self.__banner.set_reveal_child(True) main_widget = self.__stack.get_child_by_name("main") if main_widget is not None: main_widget.set_margin_top(self.__banner.height + MARGIN_SMALL) + elif reveal == Reveal.FALSE: + self.__banner.set_reveal_child(False) def _on_map(self, widget): """ @@ -305,8 +314,15 @@ @return int """ value = adj.get_value() - reveal = self.scrolled_value > value - self.scrolled_value = value + if (self.scrolled_value > value + REVEAL_DELTA): + reveal = Reveal.TRUE + self.scrolled_value = value + elif (self.scrolled_value < value - REVEAL_DELTA): + reveal = Reveal.FALSE + self.scrolled_value = value + else: + reveal = Reveal.NONE + return reveal def __on_banner_height_changed(self, banner, height): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.4.39/meson.build new/lollypop-1.4.40/meson.build --- old/lollypop-1.4.39/meson.build 2024-04-14 10:52:33.000000000 +0200 +++ new/lollypop-1.4.40/meson.build 2024-06-13 13:53:56.000000000 +0200 @@ -1,5 +1,5 @@ project('lollypop', - version: '1.4.39', + version: '1.4.40', meson_version: '>= 0.46.0' ) revision = run_command('bin/revision.sh').stdout().strip() ++++++ lollypop.obsinfo ++++++ --- /var/tmp/diff_new_pack.0mTHnN/_old 2024-06-24 20:54:16.658470231 +0200 +++ /var/tmp/diff_new_pack.0mTHnN/_new 2024-06-24 20:54:16.662470378 +0200 @@ -1,5 +1,5 @@ name: lollypop -version: 1.4.39 -mtime: 1713084753 -commit: bc2195de11bd67bd69e924e64cb290fd994cb11b +version: 1.4.40 +mtime: 1718279636 +commit: 5250d38610db084c81934468d94a639b3c263de3