Hello community, here is the log from the commit of package llvm7 for openSUSE:Factory checked in at 2020-09-30 19:54:45 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/llvm7 (Old) and /work/SRC/openSUSE:Factory/.llvm7.new.4249 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "llvm7" Wed Sep 30 19:54:45 2020 rev:24 rq:838614 version:7.0.1 Changes: -------- --- /work/SRC/openSUSE:Factory/llvm7/llvm7.changes 2020-07-14 08:00:38.838053402 +0200 +++ /work/SRC/openSUSE:Factory/.llvm7.new.4249/llvm7.changes 2020-09-30 19:54:55.752813557 +0200 @@ -1,0 +2,6 @@ +Mon Sep 28 21:23:19 UTC 2020 - Tom de Vries <tdevries@suse.com> + +- Fix dsymutil crash on ELF file. (bsc#1176964) + * llvm-fix-a-copy-and-paste-error-that-would-cause-a-crash.patch + +------------------------------------------------------------------- New: ---- llvm-fix-a-copy-and-paste-error-that-would-cause-a-crash.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ llvm7.spec ++++++ --- /var/tmp/diff_new_pack.suHyGu/_old 2020-09-30 19:54:57.140814798 +0200 +++ /var/tmp/diff_new_pack.suHyGu/_new 2020-09-30 19:54:57.152814809 +0200 @@ -113,6 +113,8 @@ Patch33: compiler-rt-sanitizer-ipc-perm.patch # PATCH-FIX-UPSTREAM fix-ppcle64-build.patch -- Fix ppcle64 build with newer GCC Patch34: fix-ppcle64-build.patch +# PATCH-FIX-UPSTREAM llvm-fix-a-copy-and-paste-error-that-would-cause-a-crash.patch -- Fix dsymutil crash on ELF file. +Patch35: llvm-fix-a-copy-and-paste-error-that-would-cause-a-crash.patch BuildRequires: binutils-devel >= 2.21.90 %if %{with gold} BuildRequires: binutils-gold @@ -504,6 +506,7 @@ %patch28 -p1 %patch29 -p1 %patch32 -p1 +%patch35 -p2 pushd cfe-%{_relver}.src %patch1 -p1 ++++++ llvm-fix-a-copy-and-paste-error-that-would-cause-a-crash.patch ++++++ Fix a copy and paste error that would cause a crash. Summary: The wrong variable was being checked for an error, which mean a llvm::Error went unchecked and crashes dsymutil. Discovered this when trying to feed an ELF file to "dsymutil --update" and running into the crash. Reviewers: aprantl, JDevlieghere Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75777 --- llvm/tools/dsymutil/MachODebugMapParser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/tools/dsymutil/MachODebugMapParser.cpp b/llvm/tools/dsymutil/MachODebugMapParser.cpp index 83703fb13f0a..a9d6c876860c 100644 --- a/llvm/tools/dsymutil/MachODebugMapParser.cpp +++ b/llvm/tools/dsymutil/MachODebugMapParser.cpp @@ -383,7 +383,7 @@ ErrorOr<std::vector<std::unique_ptr<DebugMap>>> MachODebugMapParser::parse() { auto Objects = ObjectEntry->getObjectsAs<MachOObjectFile>(); if (!Objects) { - return errorToErrorCode(ObjectEntry.takeError()); + return errorToErrorCode(Objects.takeError()); } std::vector<std::unique_ptr<DebugMap>> Results;