commit openSUSE-release-tools for openSUSE:Factory
Hello community, here is the log from the commit of package openSUSE-release-tools for openSUSE:Factory checked in at 2019-05-28 09:43:08 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/openSUSE-release-tools (Old) and /work/SRC/openSUSE:Factory/.openSUSE-release-tools.new.5148 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "openSUSE-release-tools" Tue May 28 09:43:08 2019 rev:183 rq:705661 version:20190527.edbb8573 Changes: -------- --- /work/SRC/openSUSE:Factory/openSUSE-release-tools/openSUSE-release-tools.changes 2019-05-27 08:40:15.539027151 +0200 +++ /work/SRC/openSUSE:Factory/.openSUSE-release-tools.new.5148/openSUSE-release-tools.changes 2019-05-28 09:43:13.005845290 +0200 @@ -1,0 +2,7 @@ +Mon May 27 12:27:08 UTC 2019 - opensuse-releaseteam@opensuse.org + +- Update to version 20190527.edbb8573: + * Exit with an error if there were exceptions caught + * ReviewBot: Simplify the !interval case + +------------------------------------------------------------------- Old: ---- openSUSE-release-tools-20190524.65b73f1d.obscpio New: ---- openSUSE-release-tools-20190527.edbb8573.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ openSUSE-release-tools.spec ++++++ --- /var/tmp/diff_new_pack.O2Dcl0/_old 2019-05-28 09:43:13.545845103 +0200 +++ /var/tmp/diff_new_pack.O2Dcl0/_new 2019-05-28 09:43:13.549845101 +0200 @@ -20,7 +20,7 @@ %define source_dir openSUSE-release-tools %define announcer_filename factory-package-news Name: openSUSE-release-tools -Version: 20190524.65b73f1d +Version: 20190527.edbb8573 Release: 0 Summary: Tools to aid in staging and release work for openSUSE/SUSE License: GPL-2.0-or-later AND MIT ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.O2Dcl0/_old 2019-05-28 09:43:13.593845086 +0200 +++ /var/tmp/diff_new_pack.O2Dcl0/_new 2019-05-28 09:43:13.593845086 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/openSUSE/openSUSE-release-tools.git</param> - <param name="changesrevision">65b73f1d416e9a7cdc337902c7aec744f4d2d334</param> + <param name="changesrevision">edbb8573b616c09400ab6da1dda27a9da07c87c5</param> </service> </servicedata> ++++++ openSUSE-release-tools-20190524.65b73f1d.obscpio -> openSUSE-release-tools-20190527.edbb8573.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openSUSE-release-tools-20190524.65b73f1d/ReviewBot.py new/openSUSE-release-tools-20190527.edbb8573/ReviewBot.py --- old/openSUSE-release-tools-20190524.65b73f1d/ReviewBot.py 2019-05-24 21:57:50.000000000 +0200 +++ new/openSUSE-release-tools-20190527.edbb8573/ReviewBot.py 2019-05-27 14:25:50.000000000 +0200 @@ -165,6 +165,8 @@ # give implementations a chance to do something before single requests self.prepare_review() + return_value = 0 + for req in self.requests: self.logger.info("checking %s"%req.reqid) self.request = req @@ -180,6 +182,7 @@ import traceback traceback.print_exc() + return_value = 1 if self.review_mode == 'no': good = None @@ -193,6 +196,8 @@ elif self.review_mode != 'accept-onpass': self._set_review(req, 'declined') + return return_value + @memoize(session=True) def request_override_check_users(self, project): """Determine users allowed to override review in a comment command.""" @@ -806,7 +811,7 @@ ${cmd_option_list} """ self.checker.set_request_ids(args) - self.checker.check_requests() + return self.checker.check_requests() @cmdln.option('-n', '--interval', metavar="minutes", type="int", help="periodic interval in minutes") def do_review(self, subcmd, opts, *args): @@ -820,9 +825,9 @@ def work(): self.checker.set_request_ids_search_review() - self.checker.check_requests() + return self.checker.check_requests() - self.runner(work, opts.interval) + return self.runner(work, opts.interval) @cmdln.option('-n', '--interval', metavar="minutes", type="int", help="periodic interval in minutes") def do_project(self, subcmd, opts, project, typename): @@ -834,9 +839,9 @@ def work(): self.checker.set_request_ids_project(project, typename) - self.checker.check_requests() + return self.checker.check_requests() - self.runner(work, opts.interval) + return self.runner(work, opts.interval) def runner(self, workfunc, interval): """ runs the specified callback every <interval> minutes or @@ -845,10 +850,15 @@ class ExTimeout(Exception): """raised on timeout""" - if interval: - def alarm_called(nr, frame): - raise ExTimeout() - signal.signal(signal.SIGALRM, alarm_called) + if not interval: + print('WORK') + r = workfunc() + print('WORK', r) + return r + + def alarm_called(nr, frame): + raise ExTimeout() + signal.signal(signal.SIGALRM, alarm_called) while True: try: @@ -856,31 +866,27 @@ except Exception as e: self.logger.exception(e) - if interval: - if os.isatty(0): - self.logger.info("sleeping %d minutes. Press enter to check now ..."%interval) - signal.alarm(interval*60) - try: - input() - except ExTimeout: - pass - signal.alarm(0) - self.logger.info("recheck at %s"%datetime.datetime.now().isoformat()) - else: - self.logger.info("sleeping %d minutes." % interval) - time.sleep(interval * 60) - - # Reset all memoize session caches which are designed for single - # tool run and not extended usage. - memoize_session_reset() - - # Reload checker to flush instance variables and thus any config - # or caches they may contain. - self.postoptparse() + if os.isatty(0): + self.logger.info("sleeping %d minutes. Press enter to check now ..."%interval) + signal.alarm(interval*60) + try: + input() + except ExTimeout: + pass + signal.alarm(0) + self.logger.info("recheck at %s"%datetime.datetime.now().isoformat()) + else: + self.logger.info("sleeping %d minutes." % interval) + time.sleep(interval * 60) - continue + # Reset all memoize session caches which are designed for single + # tool run and not extended usage. + memoize_session_reset() + + # Reload checker to flush instance variables and thus any config + # or caches they may contain. + self.postoptparse() - break if __name__ == "__main__": app = CommandLineInterface() ++++++ openSUSE-release-tools.obsinfo ++++++ --- /var/tmp/diff_new_pack.O2Dcl0/_old 2019-05-28 09:43:14.241844861 +0200 +++ /var/tmp/diff_new_pack.O2Dcl0/_new 2019-05-28 09:43:14.241844861 +0200 @@ -1,5 +1,5 @@ name: openSUSE-release-tools -version: 20190524.65b73f1d -mtime: 1558727870 -commit: 65b73f1d416e9a7cdc337902c7aec744f4d2d334 +version: 20190527.edbb8573 +mtime: 1558959950 +commit: edbb8573b616c09400ab6da1dda27a9da07c87c5
participants (1)
-
root