Hello community, here is the log from the commit of package banshee for openSUSE:Factory checked in at 2013-03-01 07:12:03 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/banshee (Old) and /work/SRC/openSUSE:Factory/.banshee.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "banshee", Maintainer is "gnome-maintainers@suse.de" Changes: -------- --- /work/SRC/openSUSE:Factory/banshee/banshee.changes 2013-01-13 14:05:25.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.banshee.new/banshee.changes 2013-03-01 07:12:04.000000000 +0100 @@ -1,0 +2,6 @@ +Wed Feb 27 15:32:57 CET 2013 - hpj@opensuse.org + +- Add banshee-avoid-dbus-race.patch: fixing random crashes + (bnc#800230, bgo#692374). + +------------------------------------------------------------------- New: ---- banshee-avoid-dbus-race.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ banshee.spec ++++++ --- /var/tmp/diff_new_pack.fLcQnm/_old 2013-03-01 07:12:05.000000000 +0100 +++ /var/tmp/diff_new_pack.fLcQnm/_new 2013-03-01 07:12:05.000000000 +0100 @@ -28,6 +28,8 @@ Source99: %{name}-rpmlintrc # PATCH-FIX-UPSTREAM banshee-dmcs-before-gmcs.patch bnc#798267 dimstar@opensuse.org -- Favor dmcs over gmcs... Fixes issues with mono 3.0. Taken from git Patch0: banshee-dmcs-before-gmcs.patch +# PATCH-FIX-UPSTREAM banshee-avoid-dbus-race.patch bnc#800230 bgo#692374 hpj@opensuse.org -- Fixes random crashes with new D-Bus. +Patch1: banshee-avoid-dbus-race.patch BuildRequires: fdupes BuildRequires: gnome-doc-utils-devel BuildRequires: intltool @@ -265,6 +267,7 @@ %prep %setup -q %patch0 -p1 +%patch1 -p1 translation-update-upstream po banshee %build ++++++ banshee-avoid-dbus-race.patch ++++++

From 459be46e3bd086deba369f367e6198d0b25f1a7c Mon Sep 17 00:00:00 2001 From: Hans Petter Jansson <hpj@cl.no> Date: Tue, 26 Feb 2013 02:43:37 +0100 Subject: [PATCH] Avoid race when using GConf and DBus with threads

GConf causes us to make indirect calls to libdbus from multiple threads, resulting in crashes if left uninitialized. As a workaround, we initialize dbus-glib for multithreading. --- .../Banshee.Gui/GtkBaseClient.cs | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseClient.cs b/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseClient.cs index c5c5675..1df06ad 100644 --- a/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseClient.cs +++ b/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseClient.cs @@ -28,6 +28,7 @@ using System; using System.IO; +using System.Runtime.InteropServices; using Mono.Addins; @@ -100,6 +101,10 @@ namespace Banshee.Gui { } + internal const string LIBDBUSGLIB1 = "libdbus-glib-1.so.2"; + [DllImport (LIBDBUSGLIB1, CallingConvention=CallingConvention.Cdecl, SetLastError=true)] + internal static extern void dbus_g_thread_init (); + protected virtual void InitializeGtk () { Log.Debug ("Initializing GTK"); @@ -107,6 +112,9 @@ namespace Banshee.Gui if (!GLib.Thread.Supported) { GLib.Thread.Init (); } + + dbus_g_thread_init (); + Gtk.Application.Init (); if (ApplicationContext.CommandLine.Contains ("debug-gtkrc")) { -- 1.7.7 -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org