Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package oo7 for openSUSE:Factory checked in at 2024-06-24 20:53:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/oo7 (Old) and /work/SRC/openSUSE:Factory/.oo7.new.18349 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "oo7" Mon Jun 24 20:53:13 2024 rev:3 rq:1182656 version:0.3.3 Changes: -------- --- /work/SRC/openSUSE:Factory/oo7/oo7.changes 2024-05-17 20:07:09.195697726 +0200 +++ /work/SRC/openSUSE:Factory/.oo7.new.18349/oo7.changes 2024-06-24 20:54:23.846733237 +0200 @@ -1,0 +2,7 @@ +Sat Jun 22 16:17:31 UTC 2024 - Richard Rahl <rrahl0@disroot.org> + +- update to 0.3.3: + * client/item: Force tuple usage when serializing + * client: Use async UnixStream + +------------------------------------------------------------------- Old: ---- oo7-0.3.2.tar.gz New: ---- oo7-0.3.3.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ oo7.spec ++++++ --- /var/tmp/diff_new_pack.s0d9m4/_old 2024-06-24 20:54:24.898771729 +0200 +++ /var/tmp/diff_new_pack.s0d9m4/_new 2024-06-24 20:54:24.898771729 +0200 @@ -17,7 +17,7 @@ Name: oo7 -Version: 0.3.2 +Version: 0.3.3 Release: 0 Summary: James Bond went on a new mission as a Secret Service provider License: MIT ++++++ _service ++++++ --- /var/tmp/diff_new_pack.s0d9m4/_old 2024-06-24 20:54:24.926772753 +0200 +++ /var/tmp/diff_new_pack.s0d9m4/_new 2024-06-24 20:54:24.930772899 +0200 @@ -3,10 +3,6 @@ <service name="download_files" mode="manual" /> <service name="cargo_vendor" mode="manual"> <param name="src">*.tar.gz</param> - <param name="cargotoml">Cargo.toml</param> - <param name="cargotoml">cli/Cargo.toml</param> - <param name="cargotoml">client/Cargo.toml</param> - <param name="cargotoml">portal/Cargo.toml</param> </service> </services> ++++++ oo7-0.3.2.tar.gz -> oo7-0.3.3.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/oo7-0.3.2/Cargo.toml new/oo7-0.3.3/Cargo.toml --- old/oo7-0.3.2/Cargo.toml 2024-05-05 13:32:51.000000000 +0200 +++ new/oo7-0.3.3/Cargo.toml 2024-06-18 13:54:58.000000000 +0200 @@ -8,7 +8,7 @@ ] [workspace.package] -version = "0.3.2" +version = "0.3.3" edition = "2021" authors = ["Bilal Elmoussaoui", "Sophie Herold", "Maximiliano Sandoval"] keywords = ["keyring", "secret", "service", "portal", "keychain"] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/oo7-0.3.2/client/Cargo.toml new/oo7-0.3.3/client/Cargo.toml --- old/oo7-0.3.2/client/Cargo.toml 2024-05-05 13:32:51.000000000 +0200 +++ new/oo7-0.3.3/client/Cargo.toml 2024-06-18 13:54:58.000000000 +0200 @@ -17,6 +17,7 @@ async-fs = { version = "2.1.0", optional = true } async-io = { version = "2.2.2", optional = true } async-lock = { version = "3.2.0", optional = true } +async-net = { version = "2.0.0", optional = true } blocking = { version = "1.5.1", optional = true } cbc = { version = "0.1", features = ["zeroize"], optional = true } cipher = { version = "0.4", features = [ @@ -64,6 +65,7 @@ "dep:async-fs", "dep:async-io", "dep:async-lock", + "dep:async-net", "dep:blocking", "dep:futures-lite", ] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/oo7-0.3.2/client/README.md new/oo7-0.3.3/client/README.md --- old/oo7-0.3.2/client/README.md 2024-05-05 13:32:51.000000000 +0200 +++ new/oo7-0.3.3/client/README.md 2024-06-18 13:54:58.000000000 +0200 @@ -8,8 +8,7 @@ - An implementation of the Secret Service specifications using [zbus](https://lib.rs/zbus). Which sends the secrets to a DBus implementation of the `org.freedesktop.Secrets` interface that stores them somewhere safe. -- A file backend using the `org.freedesktop.portal.Secrets` portal to retrieve the service's key to encrypt the file with. -The file format is compatible with [libsecret](https://gitlab.gnome.org/GNOME/libsecret/). +- A file backend using the `org.freedesktop.portal.Secrets` portal to retrieve the service's key to encrypt the file with. The file format is compatible with [libsecret](https://gitlab.gnome.org/GNOME/libsecret/). Sandboxed applications should prefer using the file backend as it doesn't expose the application secrets to other sandboxed applications if they can talk to the `org.freedesktop.Secrets` service. @@ -111,10 +110,7 @@ ## How does it compare to other libraries? -- [libsecret-rs](https://gitlab.gnome.org/World/Rust/libsecret-rs) provides Rust bindings of the C library [libsecret](https://gitlab.gnome.org/GNOME/libsecret/). The current main pain point with it is that -it does assume things for you so it will either use the host or the sandbox file-based keyring which makes migrating your secrets -to inside the sandbox a probably impossible task. There are also issues like <https://gitlab.gnome.org/GNOME/libsecret/-/issues/58> -that makes it not usable inside the Flatpak sandbox. +- [libsecret-rs](https://gitlab.gnome.org/World/Rust/libsecret-rs) provides Rust bindings of the C library [libsecret](https://gitlab.gnome.org/GNOME/libsecret/). The current main pain point with it is that it does assume things for you so it will either use the host or the sandbox file-based keyring which makes migrating your secrets to inside the sandbox a probably impossible task. There are also issues like <https://gitlab.gnome.org/GNOME/libsecret/-/issues/58> that makes it not usable inside the Flatpak sandbox. - [secret-service-rs](https://github.com/hwchen/secret-service-rs/) uses [zbus](https://lib.rs/zbus) internally as well but does provide a sync only API, hasn't seen an update in a while, doesn't integrate with [Secret portal](https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal...) if sandboxed. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/oo7-0.3.2/client/src/dbus/api/item.rs new/oo7-0.3.3/client/src/dbus/api/item.rs --- old/oo7-0.3.2/client/src/dbus/api/item.rs 2024-05-05 13:32:51.000000000 +0200 +++ new/oo7-0.3.3/client/src/dbus/api/item.rs 2024-06-18 13:54:58.000000000 +0200 @@ -135,7 +135,7 @@ #[doc(alias = "SetSecret")] pub async fn set_secret(&self, secret: &Secret<'_>) -> Result<(), Error> { self.inner() - .call_method("SetSecret", &(secret)) + .call_method("SetSecret", &(secret,)) .await .map_err::<ServiceError, _>(From::from)?; Ok(()) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/oo7-0.3.2/client/src/portal/secret.rs new/oo7-0.3.3/client/src/portal/secret.rs --- old/oo7-0.3.2/client/src/portal/secret.rs 2024-05-05 13:32:51.000000000 +0200 +++ new/oo7-0.3.3/client/src/portal/secret.rs 2024-06-18 13:54:58.000000000 +0200 @@ -1,14 +1,16 @@ //! Implementation of the XDG secret portal. //! //! This is a modified copy from ASHPD. -use std::{ - collections::HashMap, - io::Read, - os::{fd::AsFd, unix::net::UnixStream}, -}; +use std::{collections::HashMap, os::fd::AsFd}; +#[cfg(feature = "async-std")] +use async_net::unix::UnixStream; +#[cfg(feature = "async-std")] +use futures_util::AsyncReadExt; use futures_util::StreamExt; use rand::{distributions::Alphanumeric, thread_rng, Rng}; +#[cfg(feature = "tokio")] +use tokio::{io::AsyncReadExt, net::UnixStream}; use zbus::{ zvariant::{Fd, ObjectPath, OwnedValue, SerializeDict, Type}, ProxyDefault, @@ -158,13 +160,11 @@ Err(e) => Err(e.into()), }?; - // FIXME Use async-std's (tokio's) UnixStream once - // https://github.com/async-rs/async-std/pull/1036 is in. let (mut x1, x2) = UnixStream::pair()?; proxy.retrieve_secret(&x2).await?; drop(x2); let mut buf = Vec::new(); - x1.read_to_end(&mut buf)?; + x1.read_to_end(&mut buf).await?; #[cfg(feature = "tracing")] tracing::debug!("Secret received from the portal successfully"); ++++++ vendor.tar.zst ++++++ /work/SRC/openSUSE:Factory/oo7/vendor.tar.zst /work/SRC/openSUSE:Factory/.oo7.new.18349/vendor.tar.zst differ: char 7, line 1