Hello community, here is the log from the commit of package cantata for openSUSE:Factory checked in at 2018-04-30 22:57:15 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/cantata (Old) and /work/SRC/openSUSE:Factory/.cantata.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "cantata" Mon Apr 30 22:57:15 2018 rev:8 rq:602401 version:2.3.0 Changes: -------- --- /work/SRC/openSUSE:Factory/cantata/cantata.changes 2018-03-28 10:32:48.237975885 +0200 +++ /work/SRC/openSUSE:Factory/.cantata.new/cantata.changes 2018-04-30 22:59:15.535759985 +0200 @@ -1,0 +2,56 @@ +Sun Apr 29 21:32:58 UTC 2018 - cornelis@solcon.nl + +- Replace fix-no-return-in-nonvoid-function.diff with patch from + upstream + +------------------------------------------------------------------- +Sat Apr 28 20:16:49 UTC 2018 - cornelis@solcon.nl + +- For now disable remote device support. The dbus service that comes + with it needs a security audit. +- Remove cantata.rpmlintrc: it dealt with the dbus service rpmlint + error in a way not allowed in factory. + +------------------------------------------------------------------- +Sat Apr 28 16:36:41 UTC 2018 - enzokiel@kabelmail.de + + - Added fix-no-return-in-nonvoid-function.diff and + cantata.rpmlintrc. + +------------------------------------------------------------------- +Fri Apr 27 21:19:16 UTC 2018 - cornelis@solcon.nl + +- Use %license for LICENSE for newer versions. + +------------------------------------------------------------------- +Fri Apr 27 20:08:51 UTC 2018 - cornelis@solcon.nl + +- Update to 2.3.0: + * Only disable system tray support if org.kde.StatusNotifierWatcher + is not registered when running under Gnome. + * Add ability to change grid cover size - Ctrl+ / Ctrl- + * Avahi support (automatic mpd discovery) + * Make serving of files to MPD via HTTP configurable. + * Improved transcode options. + * If dynamic playlists helper does not start, show link to wiki + page detailing perl dependencies. + * Add "Add Local Files" to playqueue context menu. + * Remember last loaded/saved playlist name - and use this as the + default name when saving. + * Add option to show bitrate, sample rate, and format in toolbar. + * Add support for forked-DAAP - thanks to Wolfgang Scherer. + * Add checkbox to indicate that server auto-updates when files + changed. Thanks to Wolfgang Scherer. + * Make it possible to filter on year (or range of years) in library + and playqueue search fields. + * Enable remote (sshfs, samba) device support by default for Linux builds. + * Re-add option to show menumbar for Linux builds if not run under GNOME. + * Work-around Cantata preventing logout under GNOME/KDE if set to + minimise to system tray and main window is open. + * Fix reading embedded covers from OGG files. + * Fetch missing covers from iTunes. + * And more, see https://github.com/CDrummond/cantata/releases +- Deleted now included patches: fix-prevent-logout.patch and + fix-qt-510.patch + +------------------------------------------------------------------- Old: ---- cantata-2.2.0.tar.gz fix-prevent-logout.patch fix-qt-510.patch New: ---- cantata-2.3.0.tar.gz fix-no-return-in-nonvoid-function.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ cantata.spec ++++++ --- /var/tmp/diff_new_pack.z2ijFB/_old 2018-04-30 22:59:16.383729043 +0200 +++ /var/tmp/diff_new_pack.z2ijFB/_new 2018-04-30 22:59:16.387728897 +0200 @@ -17,7 +17,7 @@ Name: cantata -Version: 2.2.0 +Version: 2.3.0 Release: 0 Summary: Client for the Music Player Daemon (MPD) License: GPL-3.0-only @@ -27,10 +27,8 @@ # PATCH-FIX-OPENSUSE fix-translations-with-qt5.diff -- Make sure that it finds the right lrelease and lconvert binaries with Qt5 Patch1: fix-translations-with-qt5.diff Patch2: install-libsolidlite.diff -# PATCH-FIX-UPSTREAM fix-qt-510.pach -- fix crash with Qt 5.10 (boo#1077468) -Patch3: fix-qt-510.patch -# PATCH-FIX-UPSTREAM: https://github.com/CDrummond/cantata/issues/1183 -Patch4: fix-prevent-logout.patch +# PATCH-FIX-UPSTREAM +Patch3: fix-no-return-in-nonvoid-function.diff #Source0: https://github.com/CDrummond/cantata/archive/v%{version}.tar.gz BuildRequires: fdupes BuildRequires: media-player-info @@ -104,10 +102,11 @@ %patch1 -p0 %patch2 -p0 %patch3 -p1 -%patch4 -p1 %build -%cmake +# TODO: an dbus service is used to access remote device through sshfs or sambar +# This needs an audit (https://en.opensuse.org/openSUSE:Package_security_guidelines#DBus_Services) +%cmake -DENABLE_REMOTE_DEVICES=OFF %make_jobs %install @@ -135,7 +134,12 @@ %exclude %{_datadir}/%{name}/translations/ %{_datadir}/applications/%{name}.desktop %{_datadir}/icons/hicolor/ -%doc AUTHORS ChangeLog LICENSE README README.md TODO +%doc AUTHORS ChangeLog README README.md TODO +%if 0%{?suse_version} < 1500 +%doc LICENSE +%else +%license LICENSE +%endif %files lang -f %{name}.lang %defattr(-,root,root) ++++++ cantata-2.2.0.tar.gz -> cantata-2.3.0.tar.gz ++++++ ++++ 126610 lines of diff (skipped) ++++++ fix-no-return-in-nonvoid-function.diff ++++++

From bb421602604c30768195905201047e31331130d1 Mon Sep 17 00:00:00 2001 From: Craig Drummond <craig.p.drummond@gmail.com> Date: Sun, 29 Apr 2018 22:27:27 +0100 Subject: [PATCH] Ensure always return a value for ApiKeys::isLimitReached Closes #1255

--- gui/apikeys.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/gui/apikeys.cpp b/gui/apikeys.cpp index 5603398f8..d3e77e54d 100644 --- a/gui/apikeys.cpp +++ b/gui/apikeys.cpp @@ -132,6 +132,7 @@ bool ApiKeys::isLimitReached(Service srv) } return true; } + return false; } bool ApiKeys::isLimitReached(const QNetworkReply *job, Service srv)