commit gnome-shell for openSUSE:Factory
![](https://seccdn.libravatar.org/avatar/e2145bc5cf53dda95c308a3c75e8fef3.jpg?s=120&d=mm&r=g)
Hello community, here is the log from the commit of package gnome-shell for openSUSE:Factory checked in at 2018-12-31 09:39:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-shell (Old) and /work/SRC/openSUSE:Factory/.gnome-shell.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "gnome-shell" Mon Dec 31 09:39:13 2018 rev:157 rq:661746 version:3.30.2 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-shell/gnome-shell.changes 2018-11-18 23:25:26.657970849 +0100 +++ /work/SRC/openSUSE:Factory/.gnome-shell.new.28833/gnome-shell.changes 2018-12-31 09:39:16.498565922 +0100 @@ -1,0 +2,13 @@ +Thu Dec 27 19:57:47 UTC 2018 - bjorn.lie@gmail.com + +- Add upstream bug fix patches from stable branch: + + gnome-shell-ibusManager-Dont-pass-undefined-callback.patch: + ibusManager: Don't pass undefined callback to ibus. + + gnome-shell-altSwitcher-Fix-error-when-alternatives-are-disabled.patch: + AltSwitcher: Fix error when all alternatives are disabled. + + gnome-shell-dash-Destroy-items-child-before-tooltip.patch: + dash: destroy items's child before tooltip. + + gnome-shell-st-button-Ignore-pointer-emulated-touch-events.patch: + st-button: Ignore pointer emulated touch events. + +------------------------------------------------------------------- New: ---- gnome-shell-altSwitcher-Fix-error-when-alternatives-are-disabled.patch gnome-shell-dash-Destroy-items-child-before-tooltip.patch gnome-shell-ibusManager-Dont-pass-undefined-callback.patch gnome-shell-st-button-Ignore-pointer-emulated-touch-events.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-shell.spec ++++++ --- /var/tmp/diff_new_pack.4IyFs7/_old 2018-12-31 09:39:16.970565536 +0100 +++ /var/tmp/diff_new_pack.4IyFs7/_new 2018-12-31 09:39:16.974565534 +0100 @@ -40,6 +40,14 @@ Patch3: gnome-shell-Avoid-loginDialog-grab-focus-when-locked.patch # PATCH-FEATURE-OPENSUSE gnome-shell-fate324570-Make-GDM-background-image-configurable.patch fate#324570, glgo#GNOME/gnome-shell#680 qkzhu@suse.com -- make GDM background image configurable Patch4: gnome-shell-fate324570-Make-GDM-background-image-configurable.patch +# PATCH-FIX-UPSTREAM gnome-shell-ibusManager-Dont-pass-undefined-callback.patch -- ibusManager: Don't pass undefined callback to ibus +Patch5: gnome-shell-ibusManager-Dont-pass-undefined-callback.patch +# PATCH-FIX-UPSTREAM gnome-shell-altSwitcher-Fix-error-when-alternatives-are-disabled.patch -- AltSwitcher: Fix error when all alternatives are disabled +Patch6: gnome-shell-altSwitcher-Fix-error-when-alternatives-are-disabled.patch +# PATCH-FIX-UPSTREAM gnome-shell-dash-Destroy-items-child-before-tooltip.patch -- dash: destroy items's child before tooltip +Patch7: gnome-shell-dash-Destroy-items-child-before-tooltip.patch +# PATCH-FIX-UPSTREAM gnome-shell-st-button-Ignore-pointer-emulated-touch-events.patch -- st-button: Ignore pointer emulated touch events +Patch8: gnome-shell-st-button-Ignore-pointer-emulated-touch-events.patch ## NOTE: Keep SLE-only patches at bottom (starting on 1000). # PATCH-FEATURE-SLE gnome-shell-gdm-login-applet.patch fate#314545 dliang@suse.com -- Add an applet on login UI to display suse icon, product name, hostname. @@ -179,6 +187,10 @@ %patch2 -p1 %patch3 -p1 %patch4 -p1 +%patch5 -p1 +%patch6 -p1 +%patch7 -p1 +%patch8 -p1 translation-update-upstream %if !0%{?is_opensuse} ++++++ gnome-shell-altSwitcher-Fix-error-when-alternatives-are-disabled.patch ++++++
From ae0461fd60cad156c4ff6e9afc44b0520b838f50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?=
Date: Fri, 16 Nov 2018 10:39:08 +0000 Subject: [PATCH] altSwitcher: Fix error when all alternatives are disabled
While we do consider the case that we don't have a child to show for the visibility, we are still trying to move the click action unconditionally. https://gitlab.gnome.org/GNOME/gnome-shell/issues/783 (cherry picked from commit e77463b875311ff35bb94daadf2d96cb1886e2c1) --- js/ui/status/system.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/js/ui/status/system.js b/js/ui/status/system.js index c695f37be..41bcacd94 100644 --- a/js/ui/status/system.js +++ b/js/ui/status/system.js @@ -58,6 +58,9 @@ var AltSwitcher = new Lang.Class({ childToShow = this._standard; } else if (this._alternate.visible) { childToShow = this._alternate; + } else { + this.actor.hide(); + return; } let childShown = this.actor.get_child(); @@ -79,7 +82,7 @@ var AltSwitcher = new Lang.Class({ global.sync_pointer(); } - this.actor.visible = (childToShow != null); + this.actor.show(); }, _onDestroy() { -- 2.18.1 ++++++ gnome-shell-dash-Destroy-items-child-before-tooltip.patch ++++++
From 45b4495886e89373b9af6e1c3eb21bd65e1d0c42 Mon Sep 17 00:00:00 2001 From: Andrea Azzarone
Date: Fri, 16 Nov 2018 18:31:56 +0000 Subject: [PATCH] dash: destroy items's child before tooltip
Destroy the DashItemContainer's child from the same handler as the tooltip. This will prevent invalid reads when the item is destroyed while its quicklist is still open. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/781 (cherry picked from commit ff2fbf5ae40561b403b721e932d1bc5492532156) --- js/ui/dash.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/ui/dash.js b/js/ui/dash.js index 9b8bfdd13..fbc06a78e 100644 --- a/js/ui/dash.js +++ b/js/ui/dash.js @@ -52,6 +52,8 @@ var DashItemContainer = new Lang.Class({ this.animatingOut = false; this.connect('destroy', () => { + if (this.child != null) + this.child.destroy(); this.label.destroy(); }); }, -- 2.18.1 ++++++ gnome-shell-ibusManager-Dont-pass-undefined-callback.patch ++++++
From 4e1747e6ec86e765211740a76d8fabd7ff0b9269 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?=
Date: Thu, 15 Nov 2018 17:47:55 +0000 Subject: [PATCH] ibusManager: Don't pass undefined callback to ibus
Since commit 551e8278416, we don't always pass a callback parameter. However passing it on as undefined to ibus doesn't work, as gjs doesn't accept that as a valid callback value and throw an error. As a result, we can end up with no layout selected in the keyboard menu and an "empty" indicator. Fix this by explicitly passing null if no callback has been provided. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/293 (cherry picked from commit 74bb9e62492bacda372904d30891eb97685e9b0c) --- js/misc/ibusManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/misc/ibusManager.js b/js/misc/ibusManager.js index 34f198c35..33ad8777e 100644 --- a/js/misc/ibusManager.js +++ b/js/misc/ibusManager.js @@ -210,7 +210,7 @@ var IBusManager = new Lang.Class({ } this._ibus.set_global_engine_async(id, this._MAX_INPUT_SOURCE_ACTIVATION_TIME, - null, callback); + null, callback || null); }, preloadEngines(ids) { -- 2.18.1 ++++++ gnome-shell-st-button-Ignore-pointer-emulated-touch-events.patch ++++++
From 5246da5837981b6a88b83a113bd6eb346599e528 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?=
Date: Thu, 25 Oct 2018 04:35:25 +0000 Subject: [PATCH] st-button: Ignore pointer emulated touch events
In X11, pointer emulated touch events are replicated with normal PRESS, RELEASE pair events which are generated by the server. Thus for a single tap we get: - TOUCH_BEGIN -> TOUCH_END, PRESS -> RELEASE This will cause st-button to send two "clicked" signals, instead of just one, breaking extensions (like dash-to-dock) that show buttons in the main stage which will be checked two times or that will receive the same signal two times. (cherry picked from commit 4c11d15a074aeca72627c44e327e2dc2afa93ae3) --- src/st/st-button.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/st/st-button.c b/src/st/st-button.c index 8f5c4922f..a3a7b2442 100644 --- a/src/st/st-button.c +++ b/src/st/st-button.c @@ -248,14 +248,17 @@ st_button_touch_event (ClutterActor *actor, if (event->type == CLUTTER_TOUCH_BEGIN && !priv->press_sequence) { clutter_input_device_sequence_grab (device, sequence, actor); - st_button_press (button, device, 0, sequence); + if (!clutter_event_is_pointer_emulated ((ClutterEvent*) event)) + st_button_press (button, device, 0, sequence); return CLUTTER_EVENT_STOP; } else if (event->type == CLUTTER_TOUCH_END && priv->device == device && priv->press_sequence == sequence) { - st_button_release (button, device, mask, 0, sequence); + if (!clutter_event_is_pointer_emulated ((ClutterEvent*) event)) + st_button_release (button, device, mask, 0, sequence); + clutter_input_device_sequence_ungrab (device, sequence); return CLUTTER_EVENT_STOP; } -- 2.18.1
participants (1)
-
root