Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package gmmlib for openSUSE:Factory checked in at 2023-01-01 09:38:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gmmlib (Old) and /work/SRC/openSUSE:Factory/.gmmlib.new.1563 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "gmmlib" Sun Jan 1 09:38:53 2023 rev:23 rq:1045920 version:22.3.2 Changes: -------- --- /work/SRC/openSUSE:Factory/gmmlib/gmmlib.changes 2022-12-05 18:01:06.416550799 +0100 +++ /work/SRC/openSUSE:Factory/.gmmlib.new.1563/gmmlib.changes 2023-01-01 09:38:56.382805147 +0100 @@ -1,0 +2,9 @@ +Thu Dec 15 10:39:00 UTC 2022 - Dirk M��ller <dmueller@suse.com> + +- update to 22.3.2: + * Fix tiling selection + * Align SURFTYPE_3D surfaces + * Correct max surface size +- enable building for x86_64 micro-level architectures + +------------------------------------------------------------------- Old: ---- intel-gmmlib-22.3.1.tar.gz New: ---- intel-gmmlib-22.3.2.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gmmlib.spec ++++++ --- /var/tmp/diff_new_pack.SoP3UE/_old 2023-01-01 09:38:56.910808034 +0100 +++ /var/tmp/diff_new_pack.SoP3UE/_new 2023-01-01 09:38:56.918808078 +0100 @@ -19,7 +19,7 @@ %global somajor 12 %global libname libigdgmm%{somajor} Name: gmmlib -Version: 22.3.1 +Version: 22.3.2 Release: 0 Summary: Intel Graphics Memory Management Library Package License: MIT @@ -30,7 +30,7 @@ BuildRequires: c++_compiler BuildRequires: cmake BuildRequires: pkgconfig -ExclusiveArch: %ix86 x86_64 +ExclusiveArch: %ix86 x86_64 %x86_64 %description The Intel Graphics Memory Management Library provides device specific ++++++ intel-gmmlib-22.3.1.tar.gz -> intel-gmmlib-22.3.2.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/Resource/GmmResourceInfoCommonEx.cpp new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/Resource/GmmResourceInfoCommonEx.cpp --- old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/Resource/GmmResourceInfoCommonEx.cpp 2022-11-11 12:59:42.000000000 +0100 +++ new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/Resource/GmmResourceInfoCommonEx.cpp 2022-12-07 16:53:01.000000000 +0100 @@ -92,8 +92,7 @@ // Default Tiling is set to Tile64 on FtrTileY disabled platforms uint8_t IsYUVSurface = ((GmmIsPlanar(CreateParams.Format) && (!((CreateParams.Format == GMM_FORMAT_BGRP) || (CreateParams.Format == GMM_FORMAT_RGBP)))) || - (GmmIsYUVPacked(CreateParams.Format) && - !((CreateParams.Format == GMM_FORMAT_YVYU_2x1) || (CreateParams.Format == GMM_FORMAT_UYVY_2x1) || (CreateParams.Format == GMM_FORMAT_UYVY_2x1)))); + (GmmIsYUVPacked(CreateParams.Format))); CreateParams.Flags.Info.Tile4 = ((!GMM_IS_SUPPORTED_BPP_ON_TILE_64_YF_YS(BitsPerPixel)) || // 24,48,96 bpps are not supported on Tile64, Tile4 is bpp independent ((CreateParams.Type == RESOURCE_3D) && (CreateParams.Flags.Gpu.Depth || CreateParams.Flags.Gpu.SeparateStencil)) || @@ -288,6 +287,8 @@ { GMM_SET_64KB_TILE(Surf.Flags, 0, GetGmmLibContext()); GMM_SET_4KB_TILE(Surf.Flags, 1, GetGmmLibContext()); + GMM_SET_64KB_TILE(CreateParams.Flags, 0, GetGmmLibContext()); + GMM_SET_4KB_TILE(CreateParams.Flags, 1, GetGmmLibContext()); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/Resource/GmmRestrictions.cpp new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/Resource/GmmRestrictions.cpp --- old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/Resource/GmmRestrictions.cpp 2022-11-11 12:59:42.000000000 +0100 +++ new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/Resource/GmmRestrictions.cpp 2022-12-07 16:53:01.000000000 +0100 @@ -553,10 +553,6 @@ Restrictions.PitchAlignment = GFX_ALIGN(Restrictions.PitchAlignment, GMM_KBYTE(64)); } - if(GFX_GET_CURRENT_RENDERCORE(pPlatform->Platform) >= IGFX_GEN9_CORE) - { - pGmmLibContext->GetPlatformInfo().SurfaceMaxSize = GMM_TBYTE(1); - } } // SKL TileY Display needs 1MB alignment. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/Texture/GmmTextureAlloc.cpp new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/Texture/GmmTextureAlloc.cpp --- old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/Texture/GmmTextureAlloc.cpp 2022-11-11 12:59:42.000000000 +0100 +++ new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/Texture/GmmTextureAlloc.cpp 2022-12-07 16:53:01.000000000 +0100 @@ -33,6 +33,8 @@ const GMM_PLATFORM_INFO *pPlatform; pPlatform = GMM_OVERRIDE_PLATFORM_INFO(pTexInfo, pGmmLibContext); + + pTexInfo->TileMode = TILE_NONE; if(pTexInfo->Flags.Info.TiledYf || GMM_IS_64KB_TILE(pTexInfo->Flags)) { @@ -161,6 +163,8 @@ { GMM_ASSERTDPF(0, "No tiling preference set!"); } + + GMM_ASSERTDPF(pTexInfo->TileMode < GMM_TILE_MODES, "Invalid Tile Mode Set"); } ///////////////////////////////////////////////////////////////////////////////////// @@ -793,6 +797,10 @@ { SurfaceMaxSize = pPlatform->NoRestriction.MaxWidth; } + else if(pTexInfo->Flags.Gpu.TiledResource) + { + SurfaceMaxSize = GMM_TBYTE(1); + } else { SurfaceMaxSize = pPlatform->SurfaceMaxSize; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/ULT/GmmGen12dGPUResourceULT.cpp new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/ULT/GmmGen12dGPUResourceULT.cpp --- old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/ULT/GmmGen12dGPUResourceULT.cpp 2022-11-11 12:59:42.000000000 +0100 +++ new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/ULT/GmmGen12dGPUResourceULT.cpp 2022-12-07 16:53:01.000000000 +0100 @@ -46,7 +46,7 @@ pGfxAdapterInfo->SkuTable.FtrLinearCCS = 1; //legacy y =>0 - test both pGfxAdapterInfo->SkuTable.FtrStandardMipTailFormat = 1; pGfxAdapterInfo->SkuTable.FtrTileY = 1; - pGfxAdapterInfo->WaTable.WaAuxTable64KGranular = 1; + pGfxAdapterInfo->WaTable.WaTile64Optimization = 1; CommonULT::SetUpTestCase(); } } @@ -3224,3 +3224,35 @@ //Mip-mapped, MSAA case: } +/// @brief ULT for auto-tile selction in Gmm. +TEST_F(CTestGen12dGPUResource, Test2DMippedResourceAutoTiling) +{ + GMM_RESCREATE_PARAMS gmmParams = {}; + gmmParams.Type = RESOURCE_2D; + gmmParams.NoGfxMemory = 1; + gmmParams.Flags.Gpu.Texture = 1; + gmmParams.MaxLod = 5; + gmmParams.ArraySize = 4; + + for(uint32_t i = 0; i < TEST_BPP_MAX; i++) + { + TEST_BPP bpp = static_cast<TEST_BPP>(i); + gmmParams.Format = SetResourceFormat(bpp); + gmmParams.BaseWidth64 = 0x120; + gmmParams.BaseHeight = 0x120; + + GMM_RESOURCE_INFO *ResourceInfo; + ResourceInfo = pGmmULTClientContext->CreateResInfoObject(&gmmParams); + + GMM_RESOURCE_INFO *ResourceInfo2; + ResourceInfo2 = pGmmULTClientContext->CreateResInfoObject(&gmmParams); + + //Verify Gmm tile-selection able to get same tiling mode for resources created with same GmmParams + //... where 1st iteration uses auto-tile-selection, and next creates with previouly selected tile-mode. + //Below ensures, Gmm modified gmmParams to final tile-mode, or left it at initial (no tiling selection). + EXPECT_EQ(ResourceInfo->GmmGetTileMode(), ResourceInfo2->GmmGetTileMode()); + + pGmmULTClientContext->DestroyResInfoObject(ResourceInfo); + pGmmULTClientContext->DestroyResInfoObject(ResourceInfo2); + } +} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/ULT/GmmMultiAdapterULT.cpp new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/ULT/GmmMultiAdapterULT.cpp --- old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/ULT/GmmMultiAdapterULT.cpp 2022-11-11 12:59:42.000000000 +0100 +++ new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/ULT/GmmMultiAdapterULT.cpp 2022-12-07 16:53:01.000000000 +0100 @@ -133,6 +133,7 @@ void MACommonULT::GmmInitModule(uint32_t AdapterIdx, uint32_t CountIdx) { + ASSERT_TRUE(AdapterIdx < MAX_NUM_ADAPTERS); GMM_STATUS Status = GMM_SUCCESS; ADAPTER_BDF AdapterBDF = GetAdapterBDF(AdapterIdx); GfxPlatform[AdapterIdx][CountIdx].eProductFamily = GetProductFamily(AdapterIdx); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/ULT/GmmResourceULT.h new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/ULT/GmmResourceULT.h --- old/gmmlib-intel-gmmlib-22.3.1/Source/GmmLib/ULT/GmmResourceULT.h 2022-11-11 12:59:42.000000000 +0100 +++ new/gmmlib-intel-gmmlib-22.3.2/Source/GmmLib/ULT/GmmResourceULT.h 2022-12-07 16:53:01.000000000 +0100 @@ -306,7 +306,7 @@ { { 256, 256 },{ 512, 128 },{ 512, 128 },{ 1024, 64 },{ 1024, 64 } }, //TileYs { { 64, 64 },{ 128, 32 },{ 128, 32 },{ 256, 16 },{ 256, 16 } } //TileYf }; - uint32_t WMul, HMul; + uint32_t WMul = 1, HMul = 1; HAlign = 16; // RT H/VAlign VAlign = 4;