commit rpmlint for openSUSE:Factory
Hello community, here is the log from the commit of package rpmlint for openSUSE:Factory checked in at Mon May 3 23:18:24 CEST 2010. -------- --- rpmlint/rpmlint.changes 2010-04-28 11:24:38.000000000 +0200 +++ rpmlint/rpmlint.changes 2010-04-29 11:54:44.000000000 +0200 @@ -1,0 +2,10 @@ +Thu Apr 29 11:54:25 CEST 2010 - dmueller@suse.de + +- check for gethostbyname calls (bnc#506945) + +------------------------------------------------------------------- +Thu Apr 29 11:33:37 CEST 2010 - dmueller@suse.de + +- fix branding check (bnc#579556) + +------------------------------------------------------------------- calling whatdependson for head-i586 Old: ---- suse-debuginfo.diff New: ---- suse-binarieschecks.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rpmlint.spec ++++++ --- /var/tmp/diff_new_pack.b0nAAu/_old 2010-05-03 23:12:51.000000000 +0200 +++ /var/tmp/diff_new_pack.b0nAAu/_new 2010-05-03 23:12:51.000000000 +0200 @@ -23,7 +23,7 @@ BuildRequires: rpm-python Summary: Rpm correctness checker Version: 0.95 -Release: 5 +Release: 6 Source0: %{name}-%{version}.tar.bz2 Source1: config Source1001: config.in @@ -63,7 +63,7 @@ Patch5: suse-bzip-bigger-than-100k.diff Patch6: suse-filesystem.diff Patch7: suse-pkg-config-check.diff -Patch8: suse-debuginfo.diff +Patch8: suse-binarieschecks.diff Patch9: no-doc-for-lib.diff Patch10: add-scoring-support.diff Patch11: suse-file-var-run.diff ++++++ BrandingPolicyCheck.py ++++++ --- /var/tmp/diff_new_pack.b0nAAu/_old 2010-05-03 23:12:51.000000000 +0200 +++ /var/tmp/diff_new_pack.b0nAAu/_new 2010-05-03 23:12:51.000000000 +0200 @@ -40,6 +40,8 @@ # verify that it doesn't conflict with branding for r in pkg_conflicts: + if r.startswith("otherproviders("): + continue if r.find('-theme-') >= 0 or r.find('-branding-') >= 0: printError(pkg,'suse-branding-branding-conflict', r) ++++++ suse-binarieschecks.diff ++++++ --- BinariesCheck.py +++ BinariesCheck.py @@ -37,6 +37,9 @@ unused_regex = re.compile('^\s+(\S+)') exit_call_regex = re.compile('\s+FUNC\s+.*?\s+(_?exit(?:@\S+)?)(?:\s|$)') fork_call_regex = re.compile('\s+FUNC\s+.*?\s+(fork(?:@\S+)?)(?:\s|$)') + debuginfo_regex=re.compile('^\s+\[\s*\d+\]\s+\.debug_.*\s+') + symtab_regex=re.compile('^\s+\[\s*\d+\]\s+\.symtab\s+') + gethostbyname_call_regex = re.compile('\s+FUNC\s+.*?\s+(gethostbyname(?:@\S+)?)(?:\s|$)') def __init__(self, pkg, path, file, is_ar, is_shlib): self.readelf_error = False @@ -50,7 +53,10 @@ self.stack = False self.exec_stack = False self.exit_calls = [] + self.calls_gethostbyname = False fork_called = False + self.debuginfo = 0 + self.symtab=0 self.tail = '' is_debug = path.endswith('.debug') @@ -93,6 +99,11 @@ self.exec_stack = True continue + r = BinaryInfo.gethostbyname_call_regex.search(l) + if r: + self.calls_gethostbyname = True + continue + if is_shlib: r = BinaryInfo.exit_call_regex.search(l) if r: @@ -103,6 +114,14 @@ fork_called = True continue + if BinaryInfo.debuginfo_regex.search(l): + self.debuginfo=1 + continue + + if BinaryInfo.symtab_regex.search(l): + self.symtab=1 + continue + if self.non_pic: self.non_pic = 'TEXTREL' in res[1] @@ -259,6 +278,17 @@ bin_info = BinaryInfo( pkg, pkgfile.path, fname, is_ar, is_shlib) + # stripped static library + if is_ar: + if bin_info.readelf_error: + pass + elif not bin_info.symtab: + printError(pkg, 'static-library-without-symtab', fname) + elif not bin_info.debuginfo and \ + (os.environ.get('BUILD_IS_RUNNING', None) == None or \ + os.environ.get('BUILD_DEBUG_FLAGS','').find('-g') != -1): + printWarning(pkg, 'static-library-without-debuginfo', fname) + # so name in library if is_shlib: has_lib = True @@ -294,6 +324,10 @@ printError( pkg, 'shlib-with-non-pic-code', fname) + # gethostbyname ? + if bin_info.calls_gethostbyname: + printError(pkg, 'binary-or-shlib-calls-gethostbyname', fname) + # rpath ? if bin_info.rpath: for p in bin_info.rpath: @@ -509,6 +543,14 @@ 'ldd-failed', '''Executing ldd on this file failed, all checks could not be run.''', +'static-library-without-symtab', +'''The static library doesn't contain any symbols and therefore can't be linked +against. This may indicated that it was strip.''', + +'static-library-without-debuginfo', +'''The static library doesn't contain any debuginfo. Binaries linking against +this static library can't be properly debugged.''', + 'executable-stack', '''The binary declares the stack as executable. Executable stack is usually an error as it is only needed if the code contains GCC trampolines or similar @@ -521,6 +563,10 @@ make the stack executable. Usual suspects include use of a non-GNU linker or an old GNU linker version.''', +'binary-or-shlib-calls-gethostbyname', +'''The binary calls gethostbyname(). Please port the code to use +getaddrinfo().''', + 'shared-lib-calls-exit', '''This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org
participants (1)
-
root@hilbert.suse.de