Hello community, here is the log from the commit of package thinkfinger checked in at Wed Apr 16 15:53:52 CEST 2008. -------- --- thinkfinger/thinkfinger.changes 2008-04-10 23:00:28.000000000 +0200 +++ /mounts/work_src_done/STABLE/thinkfinger/thinkfinger.changes 2008-04-16 12:49:29.395346000 +0200 @@ -1,0 +2,7 @@ +Wed Apr 16 10:05:10 CEST 2008 - thoenig@suse.de + +- use pam-config to enable/disable pam_thinkfinger in %post + (bnc#300201, fate#301952) +- Bail out if pam_get_user does not return PAM_SUCCESS (bnc#380330) + +------------------------------------------------------------------- New: ---- bug-380330-user-unavailable-thoenig-01.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ thinkfinger.spec ++++++ --- /var/tmp/diff_new_pack.h28565/_old 2008-04-16 15:53:04.000000000 +0200 +++ /var/tmp/diff_new_pack.h28565/_new 2008-04-16 15:53:04.000000000 +0200 @@ -17,7 +17,7 @@ Summary: Driver for the SGS Thomson Microelectronics Fingerprint Reader BuildRequires: coreutils libusb-devel pam-devel pkgconfig Version: 0.3 -Release: 6 +Release: 7 License: GPL v2 or later Group: System/Libraries Source0: %{name}-%{version}.tar.gz @@ -25,6 +25,7 @@ Source2: pam_thinkfinger-uinput Patch0: thinkfinger-refuse-remote-login-thoenig-01.patch Patch1: bug-359216_thread-free.diff +Patch2: bug-380330-user-unavailable-thoenig-01.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build %package -n libthinkfinger @@ -39,6 +40,7 @@ PreReq: coreutils pam Group: Productivity/Security Supplements: modalias(usb:v0483p2016d*dc*dsc*dp*ic*isc*ip*) +PreReq: pam-config %description ThinkFinger is a driver for the UPEK/SGS Thomson Microelectronics @@ -78,6 +80,7 @@ %setup %patch0 -p0 %patch1 -p1 +%patch2 -p0 cp %{S:1} %{S:2} . %build @@ -102,35 +105,10 @@ %post -n pam_thinkfinger mkdir -p %{_sysconfdir}/pam_thinkfinger -if [ -f %{_sysconfdir}/pam.d/common-auth ]; then - MD5_COMMON_AUTH=14514a545a8f7948e1e157b680a8058b - MD5_CURRENT=`%{_bindir}/md5sum %{_sysconfdir}/pam.d/common-auth | cut -f1 -d " "` - if test "$MD5_CURRENT" = "$MD5_COMMON_AUTH"; then - echo "Applying PAM config..." - mv %{_sysconfdir}/pam.d/common-auth %{_sysconfdir}/pam.d/common-auth-without-pam_thinkfinger - if [ $? == 0 ]; then - cp %{_docdir}/libthinkfinger/common-auth.example %{_sysconfdir}/pam.d/common-auth - else - echo "mv failed, not applying PAM config" - fi - else - echo "Not applying PAM config..." - fi -fi +%{_sbindir}/pam-config -a --%{name} %postun -n pam_thinkfinger -if test "$1" = "0"; then - if [ -f %{_sysconfdir}/pam.d/common-auth-without-pam_thinkfinger ]; then - MD5_COMMON_THINKFINGER=8bbb482d92b23b0129cae8359e79978b - MD5_CURRENT=`%{_bindir}/md5sum %{_sysconfdir}/pam.d/common-auth | cut -f1 -d " "` - if test "$MD5_CURRENT" = "$MD5_COMMON_THINKFINGER"; then - echo "Removing PAM config..." - mv %{_sysconfdir}/pam.d/common-auth-without-pam_thinkfinger %{_sysconfdir}/pam.d/common-auth - else - echo "Not removing PAM config..." - fi - fi -fi +%{_sbindir}/pam-config -d --%{name} %post -n libthinkfinger -p /sbin/ldconfig @@ -154,6 +132,10 @@ %{_mandir}/*/pam_thinkfinger* %changelog +* Wed Apr 16 2008 thoenig@suse.de +- use pam-config to enable/disable pam_thinkfinger in %%post + (bnc#300201, fate#301952) +- Bail out if pam_get_user does not return PAM_SUCCESS (bnc#380330) * Thu Apr 10 2008 thoenig@suse.de - Add patch bug-359216_thread-free.diff: get rid of a race condition which lead to crashes of some applications using ++++++ bug-380330-user-unavailable-thoenig-01.patch ++++++ --- pam/pam_thinkfinger.c 2008-04-16 11:41:02.000000000 +0200 +++ pam/pam_thinkfinger.c 2008-04-16 11:41:00.000000000 +0200 @@ -257,7 +257,13 @@ if (pam_thinkfinger.isatty == 1) tcgetattr (STDIN_FILENO, &term_attr); - pam_get_user (pamh, &pam_thinkfinger.user, NULL); + ret = pam_get_user (pamh, &pam_thinkfinger.user, NULL); + if (ret != PAM_SUCCESS) { + pam_thinkfinger_log (&pam_thinkfinger, LOG_ERR, "No user name was provided."); + retval = PAM_USER_UNKNOWN; + goto out; + } + if (pam_thinkfinger_user_sanity_check (&pam_thinkfinger) || pam_thinkfinger_user_bir_check (&pam_thinkfinger) < 0) { pam_thinkfinger_log (&pam_thinkfinger, LOG_ERR, "User '%s' is unknown.", pam_thinkfinger.user); retval = PAM_USER_UNKNOWN; ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org
participants (1)
-
root@Hilbert.suse.de